Opened 10 years ago

Closed 7 years ago

Last modified 7 years ago

#776 closed enhancement (fixed)

Collections gallery needs better headings

Reported by: spaetz Owned by:
Priority: minor Milestone:
Component: graphic design/interface Keywords: bitesized
Cc: Parent Tickets:

Description

All media galleries show the media title underneath, not so the collections view. It does not show any heading if there is no "note" attached to the picture in a collection.

This is a problem as: a) it lets me add the media title as a collection item note to achieve the same results, which is plain nonsensical. b) it seems there are no line breaks, and the collection item note is overflowing the box, being cut off and unreadable.

We need to think about where and how to present the collection item note, I have no suggestion for that. But we should be showing the media title, just as we do in the other gallery views, IMHO.

Check this one for a problematic view: http://media.sspaeth.de/u/spaetz/collection/monitoring-monitors/

Attachments (1)

ticket776.patch (1.1 KB ) - added by saul 10 years ago.
Display note as hover text

Download all attachments as: .zip

Change History (9)

comment:1 by Christopher Allan Webber, 10 years ago

Status: newaccepted

Marking as confirmed. I agree this could use some work.

by saul, 10 years ago

Attachment: ticket776.patch added

Display note as hover text

comment:2 by saul, 10 years ago

How about displaying the entry's title underneath the thumbnail and displaying the note (if available) as hover text?

http://barn.kerosenecow.net/mgoblin_media/media_entries/452/SScollection-gallery.jpg

(Above screenshot taken from this gallery page.)

I have attached a patch that implements the above proposal.

Last edited 10 years ago by saul (previous) (diff)

comment:3 by spaetz, 9 years ago

Resolution: invalid
Status: acceptedclosed

comment:4 by spaetz, 9 years ago

Resolution: invalid
Status: closedaccepted

comment:5 by spaetz, 9 years ago

Adding the title would help already, and look much better agreed. Below patch does that and shows the abbreviated note below. Expanding that note on mouse click would be awsome, but I am no jquery expert at all...

diff --git a/mediagoblin/templates/mediagoblin/utils/collection_gallery.html b/mediagoblin/templates/mediagoblin/utils/collection_gallery.html
index 64b3081..5b45c51 100644
--- a/mediagoblin/templates/mediagoblin/utils/collection_gallery.html
+++ b/mediagoblin/templates/mediagoblin/utils/collection_gallery.html
@@ -34,8 +34,11 @@
               <img src="{{ media_entry.thumb_url }}" />
             </a>
 
+            {% if media_entry.title %}
+            <a href="{{ entry_url }}">{{ media_entry.title }}</a>
+            {% endif %}
             {% if item.note %}
-              <a href="{{ entry_url }}">{{ item.note }}</a>
+              {{ item.note }}
             {% endif %}
            {% if request.user and
                   (item.in_collection.creator == request.user.id or

comment:6 by Ben Sturmfels, 8 years ago

NZL notes in duplicate #929:

Thumbnails in the collection view are missing file title

If you look at any URL like /u/<username>/ you'll see thumbnails with the file
title included.

But if you look at any URL like /u/<username>/collection/<collectionname>/ the
same thumbnails appear but without the file title.

It seems better to have the file title also present in the collection view.

comment:7 by Ben Sturmfels, 7 years ago

Keywords: bitesized added
Status: acceptedreview

Two different patches have been provided for this ticket. Just needs someone to review them and provide feedback.

in reply to:  5 comment:8 by Boris Bobrov, 7 years ago

Resolution: fixed
Status: reviewclosed

I have merged the patch below in df2de8e, thank you for it!

Replying to spaetz:

Adding the title would help already, and look much better agreed. Below patch does that and shows the abbreviated note below. Expanding that note on mouse click would be awsome, but I am no jquery expert at all...

diff --git a/mediagoblin/templates/mediagoblin/utils/collection_gallery.html b/mediagoblin/templates/mediagoblin/utils/collection_gallery.html
index 64b3081..5b45c51 100644
--- a/mediagoblin/templates/mediagoblin/utils/collection_gallery.html
+++ b/mediagoblin/templates/mediagoblin/utils/collection_gallery.html
@@ -34,8 +34,11 @@
               <img src="{{ media_entry.thumb_url }}" />
             </a>
 
+            {% if media_entry.title %}
+            <a href="{{ entry_url }}">{{ media_entry.title }}</a>
+            {% endif %}
             {% if item.note %}
-              <a href="{{ entry_url }}">{{ item.note }}</a>
+              {{ item.note }}
             {% endif %}
            {% if request.user and
                   (item.in_collection.creator == request.user.id or

Last edited 7 years ago by Boris Bobrov (previous) (diff)
Note: See TracTickets for help on using tickets.