Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#754 closed enhancement (fixed)

consider adding WAI-ARIA attributes to the header dropdown

Reported by: Aleksej Owned by:
Priority: trivial Milestone: 0.7.0
Component: programming Keywords: access
Cc: Parent Tickets:

Description

I don't understand what I'm doing, but here is a patch that adds aria-controls attribute that, according to a candidate recommendation (http://www.w3.org/TR/wai-aria/states_and_properties#aria-controls), is supposed to tell some software that the down/up arrow icon controls the header drop-down.

At least it *hopefully* doesn't break anything and doesn't add any requirements for more attributes.

Attachments (1)

header_dropdown_id_aria_controls.diff (2.1 KB ) - added by Aleksej 11 years ago.
patch (adds aria-control and changes a class attribute to id accordingly)

Download all attachments as: .zip

Change History (6)

by Aleksej, 11 years ago

patch (adds aria-control and changes a class attribute to id accordingly)

comment:1 by rodney757, 11 years ago

Status: newreview

comment:2 by rodney757, 11 years ago

What is the reason for changing the class to an id?

comment:3 by Aleksej, 11 years ago

http://www.w3.org/TR/wai-aria/states_and_properties#aria-controls says "Value: ID reference list", linking to http://www.w3.org/TR/wai-aria/states_and_properties#valuetype_idref_list which says "ID reference list: A list of one or more ID references." and "ID reference: Reference to the ID of another element in the same document".

comment:4 by Christopher Allan Webber, 10 years ago

Resolution: fixed
Status: reviewclosed

Good patch. All that was missing was adjusting the CSS properties.

I committed this in commit 4b24678... thank you!

comment:5 by Christopher Allan Webber, 10 years ago

Milestone: 0.7.0
Note: See TracTickets for help on using tickets.