Opened 10 years ago
Closed 10 years ago
Last modified 10 years ago
#753 closed defect (fixed)
better redirect after delete confirm
|Reported by:||alon||Owned by:|
The current behavior is to return to the user view. That loses context. Better to move to the next or the previous item using the existing next/prev logic.
In addition this commit request contains a fix for a one off bug in get_media_type_and_manager
Change History (6)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
|Status:||new → review|
comment:3 by , 10 years ago
|Status:||review → closed|
So I merged the redirect commit.
The other commit i didn't merge. If you do os.path.splitext on a file that starts with '.', the ext is at the 0 index instead of the 1 index, so we would need to account for this.
I'm going to close this ticket, as it was for the redirect, but feel free to submit a patch for the ext issue.
comment:4 by , 10 years ago
Thanks for merging the redirect fix.
Regarding the second commit: That was exactly the point - that the current code misses the case of doing something like:
This is useful for my yet-to-be-merged importmedia command.
comment:5 by , 10 years ago
Sorry if I wasn't clear, but
os.path.splitext returns a tuple. when the filename is say
test.jpg, the extension is in the 1 index of the returned tuple, but when the filename is
.jpg, the ext is in the 0 index of the tuple. Mediagoblin expects the extension to be at position 1, not position 0, so we would need to account for this.
comment:6 by , 10 years ago