#5620 closed defect (fixed)
Download link missing on 0.10
| Reported by: | TmCTux | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.11.0 |
| Component: | programming | Keywords: | |
| Cc: | thomzane | Parent Tickets: |
Description
Hello,
since the new version, when displaying a video, under the label "download" there isn't the link to download the media anymore.
It's still there on all the other media page generated before migration though.
I've raise the priority to major because although mediagoblin can be viewed as a streaming website, this link is mandatory for iOS user where the video viewer is not compatible and it was their only mean to actually watch the video.
thanks again!
Change History (12)
comment:1 by , 4 years ago
comment:2 by , 4 years ago
Hello,
as said it is occuring only for video generated after migration (I don't upload video through webui but as before I only use command line to do so, not it should matter). So old video has still the link, only the one uploaded after migration has the link missing.
I'm using the default MediaGoblin theme.
thanks
comment:4 by , 3 years ago
| Cc: | added |
|---|---|
| Owner: | set to |
| Status: | new → in_progress |
I've looked into the missing download link on MediaGoblin 0.10.0 and this is related to the new multiple video qualities feature. The sidebar in mediagoblin/templates/mediagoblin/media_displays/video.html hasn't been updated to reflect the new feature.
I'll look into a fix.
CC'ing thomzane as I know Michael had run up against this issue.
comment:5 by , 3 years ago
| Milestone: | → 0.11.0 |
|---|
comment:6 by , 3 years ago
| Cc: | added; removed |
|---|
comment:7 by , 3 years ago
I did run into this issue as seen here with Ben's video coincidentally: https://media.libreplanet.org/u/libreplanet/m/rock-your-emacs-ad5a/
After forcing skipping the transcoding in mediagoblin/media_types/video/util.py, download links appeared again in uploads after this as seen here: https://media.libreplanet.org/u/libreplanet/m/celebrating-35-years-of-fsf-by-fsf-president-geoffrey-knauth/
comment:8 by , 3 years ago
Great, thanks Michael. It sounds like we might have two separate issues then. One is the download links for the transcoded versions aren't showing up. The second is to do with originals.
The originals is an interesting one for video - unless you've pre-transcoded the video, the original isn't really suitable for distribution because it's probably excessively large. So this is specific to the case that the upload is already transcoded. That will need some thought as to how it works with multi-resolution video.
follow-up: 11 comment:9 by , 3 years ago
I've just pushed a change to master that will reinstate the video download links for the multiple resolution transcoded versions. This should resolve TmCTux's issue. I haven't looked at Michael's missing original version link yet.
comment:10 by , 3 years ago
(And sorry for the delay TmCTux - if you've stuck around, I'd be glad to hear if this resolves your issue.)
comment:11 by , 3 years ago
| Owner: | removed |
|---|---|
| Resolution: | → fixed |
| Status: | in_progress → closed |
Replying to Ben Sturmfels:
I've just pushed a change to master that will reinstate the video download links for the multiple resolution transcoded versions. This should resolve TmCTux's issue. I haven't looked at Michael's missing original version link yet.
Michael mentioned that he has a workaround for his issue, so I'll close this ticket.
Regards,
Ben
comment:12 by , 3 years ago
thanks a lot for spending times on this, it is indeed fixed on my side as well.
Hi TmCTux, thanks for letting us know about this.
Is this only occurring on new videos, or also on videos uploaded before 0.10.0?
Also you using the default MediaGoblin theme?
Regards,
Ben