Opened 10 years ago

Closed 9 years ago

#536 closed enhancement (fixed)

GNU Coding Standards-compliant configure script & Makefile

Reported by: Brandon Invergo Owned by:
Priority: major Milestone: 0.5.0
Component: infrastructure Keywords:
Cc: Stephen Compall Parent Tickets:

Description

According to the GNU Coding Standards, all GNU projects should have a configure script and a Makefile. I've gone ahead and made such a script based on some new Autoconf macros. The included Makefile.in is largely a wrapper around setup.py. It also includes some extra touches, like installing to a Virtualenv and building the docs. This should all be standards compliant now. As the project grows, I'll be happy to help a bit with modifying the scripts.

Note: these files are part of the (as-of-yet un-announced) new GNU package pyconfigure. Over there I'll be working steadily to make these more powerful than just wrapper scripts. I'll keep you abreast of any interesting developments.

The changes are available here:
https://gitorious.org/mediagoblin/mediagoblin-pyconfigure/commit/52aef5b445710dbe800ebba7f44ca0cc0e06ea54/diffs/ef513974abdd60284b4c32371acbe9ee0eb9c019

Subtickets

Change History (10)

comment:1 Changed 10 years ago by Brandon Invergo

I'm sorry to say that there are some bugs in this. I'll implement a new version and post it here ASAP, but please don't even test this version...spare me the embarrassment!

comment:2 Changed 10 years ago by Stephen Compall

Cc: Stephen Compall added

comment:3 Changed 10 years ago by Christopher Allan Webber

Any updates on this btw? I see http://www.gnu.org/software/pyconfigure/ but have no idea on the state of it.

comment:4 Changed 10 years ago by Christopher Allan Webber

Status: newreview

Brandon has provided code here:

https://gitorious.org/~brandoninvergo/mediagoblin/mediagoblin-pyconfigure

See also:

http://lists.mediagoblin.org/pipermail/devel/2013-May/000564.html

He's asking for feedback so I'm going to mark this as "review" :)

comment:5 Changed 10 years ago by Christopher Allan Webber

Owner: set to Brandon Invergo
Status: reviewin_progress

I replied to this on-list:

http://lists.mediagoblin.org/pipermail/devel/2013-May/000565.html

As such I'm passing this back to brandon!

comment:6 Changed 10 years ago by Christopher Allan Webber

Milestone: 0.4.1
Owner: Brandon Invergo deleted
Status: in_progressreview

This is pretty much ready for merge, but since 0.4.0 is so close and it's a huge change to document, I'm marking it for 0.4.1.

I still think we should keep setup.py as is; we don't need setup.py.in for now. Other things seem good.

Brandon, is there anything else you intend to do to this? I've moved to "review", but that's more a cue that it should be merged. If you're working on it and think it needs some other things before merge, please re-claim.

comment:7 Changed 10 years ago by Brandon Invergo

Nope, I'm all done I think. But obviously feel free to contact me in the future whenever you need to add/change something.

As for the setup.py.in thing, no problem. Should I revert it in my branch first or will you take care of it?

comment:8 Changed 10 years ago by Christopher Allan Webber

Owner: set to Christopher Allan Webber
Status: reviewin_progress

I'll take care of it... in fact I'm working on this today!

comment:9 Changed 10 years ago by Christopher Allan Webber

I'm working on the final steps of this here, including updating docs: https://gitorious.org/~cwebber/mediagoblin/cwebbers-mediagoblin

One thing I'm very nervous about: docs.mediagoblin.org just shows the latest docs that are in git. This is no longer acceptable because people installing from 'stable' (the latest tag) will have a broken experience.

I need to figure out a way to fix that. See #737 which is a ticket to address that.

comment:10 Changed 9 years ago by Christopher Allan Webber

Owner: Christopher Allan Webber deleted
Resolution: fixed
Status: in_progressclosed

We moved to readthedocs. So I merged this! Horray!

Note: See TracTickets for help on using tickets.