Opened 12 years ago
Closed 12 years ago
#537 closed defect (fixed)
Show what version number a site is running in footer hover text
Reported by: | Christopher Allan Webber | Owned by: | pythonsnake |
---|---|---|---|
Priority: | major | Milestone: | 0.3.3 |
Component: | programming | Keywords: | bitesized, review |
Cc: | Parent Tickets: |
Description
schendje came up with this good solution to having version numbers in the footer. It wouldn't be hard to implement. Attaching an image to explain, but basically hovering over "mediagoblin" should show the version number.
This should be easy to implement. The version number is already available in mediagoblin/mediagoblin/version.py ... import that, and insert it in mediagoblin.tools.template:get_jinja_env, where we have stuff like:
# All templates will know how to ... # ... fetch all waiting messages and remove them from the queue # ... construct a grid of thumbnails or other media # ... have access to the global and app config template_env.globals['fetch_messages'] = messages.fetch_messages template_env.globals['gridify_list'] = gridify_list template_env.globals['gridify_cursor'] = gridify_cursor template_env.globals['app_config'] = mg_globals.app_config template_env.globals['global_config'] = mg_globals.global_config
This is an easy task, perfect for a new contributor.
Attachments (1)
Change History (8)
by , 12 years ago
Attachment: | mediagoblin_version.png added |
---|
comment:1 by , 12 years ago
I put "GNU MediaGoblin version x.y.z" as the title attribute. Let's change that to just "Version x.y.z" as to not repeat "GNU" or "MediaGoblin".
comment:2 by , 12 years ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:3 by , 12 years ago
I've fixed that: https://github.com/pythonsnake/MediaDwarf/tree/537_version
comment:4 by , 12 years ago
Keywords: | review added |
---|
comment:5 by , 12 years ago
That looks great, pythonsnake, thanks!
Only thing: let's change the title attribute from:
{{ version }}
...to:
Version {{ version }}
comment:7 by , 12 years ago
Milestone: | → 0.3.3 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Merged this! (0c8073a3a39ce9b4b006e6b2960d6591ddf24aa7
).
Thanks!
Mediagoblin version hovertext