Convert all mongokit style .find, .find_one, .one calls over to SQLAlchemy queries

[Christopher Allan Webber]

Right now (esp thanks to Elrond) we managed to have a nice transitional period between Mongo and SQL by having mongokit like queries via .find() .find_one() and .one() reproduction for SQLAlchemy. But it's time to remove those from the codebase. We should start removing all instances of those and replacing them with proper queries.

[Christopher Allan Webber]

Elrond seems unsure that we should remove these, last I spoke to him, for this reason: the mongokit-style queries look pretty nice, and they seem to work well. This is true, but I think it's also true that the less types of syntax our devs need to learn, the better.

The result is that I think this is slightly lower priority, but if someone works on this I'll definitely merge it.

[Will Kahn-Greene]

I'm bumping this out of the 0.3.1 milestone. I don't think it was done for 0.3.1 and it's not assigned to anyone.

[spaetz]

Is this what we have in mind: see my branch 451_mongolisms. Not complete, but a first step.git://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin.git

[spaetz]

I just merged the above branch (master changed from 2783c65 to 70f8b2d) removing mongolisms from auth.views and user_pages. There are still quite a few remaining that need to be done though.

[Elrond]

I think, we're done with this for the big part.

The remaining ones can be fixed "on the go". They don't hurt. They're getting handled by our wrapper tools.

I vote for closing.

[Christopher Allan Webber]

I think it's worth leaving open until these are closed.

[Christopher Allan Webber]

If someone wants to pick this up, it's not really a complex ticket, it's just very manual. Moving to 0.3.4 anyway.

[Ben Sturmfels]

Replace transitional calls to 'first_one()' with 'filter_by().first()'.

[Ben Sturmfels]

I've attached a patch to replace calls to first_one(). I'm happy to proceed with the others, but would love someone to take a quick look to make sure I'm on the right track. (Tests still pass)

[rodney757]

Your one the right track :)

Now only .find and .one to go.

Thanks

[Ben Sturmfels]

Replace transitional calls to 'find_one()', 'find()', and 'one()'.

[Ben Sturmfels]

Thanks rodney757. I've attached an updated patch replacing all of find_one(), find() and one().

[rodney757]

Okay, So I looked over this and everything looks good to me. All tests pass as well.

I talked to cwebb on irc about the db.MediaEntry.query.filter_by() in gmg_commands/import_export.py and we agreed that this is probably better then using .query.all() since it returns a query object vs a list.

[rodney757]

Committed! Thanks for the patch.