Opened 9 years ago

Closed 8 years ago

#349 closed enhancement (fixed)

Feed for all items

Reported by: maiki interi Owned by: Christopher Allan Webber
Priority: minor Milestone: 0.3.3
Component: other Keywords: review
Cc: Parent Tickets:

Description (last modified by Christopher Allan Webber)

Unless I am mistaken, there isn't a feed containing all the items
uploaded to a site. I think that would be useful. =]



Subtickets

Change History (15)

comment:1 Changed 9 years ago by Will Kahn-Greene

The original url for this bug was http://bugs.foocorp.net/issues/701 .

comment:2 Changed 9 years ago by Sacha

Milestone: 0.2.2
Owner: set to Sacha
Status: acceptedassigned

basically copy the tag_atom_feed but remove the tags in views.py and add the view to /mediagoblin/routing.py

comment:3 Changed 9 years ago by Sacha

Owner: changed from Sacha to Christopher Allan Webber

Got it working, test by going to .../all in lazyserver.

Code is here:
https://gitorious.org/~chemhacker/mediagoblin/chemhackers-mediagoblin/commits/349_rssfeed

comment:4 Changed 8 years ago by joar

Owner: changed from Christopher Allan Webber to Sacha

The tag_slug is set to empty in the view although it is used to construct the Tag URI (https://en.wikipedia.org/wiki/Tag_URI) for the feed. It'd be awesome if we'd have an appropriate tag URI there instead :)

Also the feed URL is a bit misleading, /all/atom/ would be a better URL.

comment:5 Changed 8 years ago by Christopher Allan Webber

Description: modified (diff)
Milestone: 0.3.00.3.1
Owner: changed from Sacha to Christopher Allan Webber

I'll take a look at this today. Those changes Joar suggests should be pretty simple, I think?

comment:6 Changed 8 years ago by Christopher Allan Webber

I obviously haven't gotten to this yet. I'll try to get to it soon, but if someone else wants to move on to reviewing it, they're welcome to.

comment:7 Changed 8 years ago by Will Kahn-Greene

Did this ever get reviewed?

comment:8 Changed 8 years ago by Christopher Allan Webber

This hasn't gotten reviewed, no.

If someone wants to pick it up and review it, that would be helpful. I can't get to it until after the campaign launches.

comment:9 Changed 8 years ago by spaetz

I have reviewed the code now. Rebased to latest master (some conflicts in routing.py) and pushed to my git repo at: git://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin.git branch 349_rssfeed

The code is obviously still Sacha De'Angeli's, thanks for the patch chemhacker!

What is missing:

  • No changes to the templates yet, an Atom Feed link needs to be integrated into the homepage where all latest entries are shown (the Atom feed IS advertized in the HEAD part already though).
  • Template and atom_feed function are a copy based on the tag_atom_feed, and while I recommend to merge the patch as is, I would also recommend that we look into refactoring the Atom Feed functions into a common core as a second step (otherwise we'll get the same functions for users, tags, years, etc...)

comment:10 Changed 8 years ago by spaetz

I just pushed a second commit on top to the branch that cleans up the commit a little further and modifies the "root" template to show the atom feed icon and link as this is where the "most recent media feed" belongs IMHO. The second commit also deletes templates/listings/all.html as contributed by chemhacker as it was unused and not needed.

What remains to be done is to refactor the various feed functions in views.py, consolidating them to one.

comment:11 Changed 8 years ago by spaetz

Milestone: 0.3.10.3.3

comment:12 Changed 8 years ago by spaetz

Actually, I believe this issue should be merged into the new lxml-based atom feed branch that I am creating for issue #358. This is a clean and new atom feed branch that avoids duplication as much as possible.

comment:13 Changed 8 years ago by Christopher Allan Webber

Owner: changed from Christopher Allan Webber to spaetz

comment:14 Changed 8 years ago by spaetz

Keywords: review added
Owner: changed from spaetz to Christopher Allan Webber

While the long-term solution will be to move to the lxml-based solution, here is a short term solution, reusing the existing tag_feed view to also provide the all-recent-items feed. See the 2 patches in my branch 349_rssfeed which are ready for review and integration. Reassigning to cwebber to review and OK my branch.

comment:15 Changed 8 years ago by Christopher Allan Webber

Resolution: fixed
Status: assignedclosed

Merged! (Or more accurately, cherry picked.) Thanks! :)

Note: See TracTickets for help on using tickets.