Opened 11 years ago
Last modified 11 years ago
#226 closed defect (FIXED)
Small code picks
Reported by: | Elrond | Owned by: | Christopher Allan Webber |
---|---|---|---|
Priority: | minor | Milestone: | 0.1.0 |
Component: | programming | Keywords: | |
Cc: | Parent Tickets: |
Description
pre word¶ ========= While reviewing the late changes, I found some things, I would like to be considered. edit\_media() references attachments.¶ -------------------------------------- ``edit_media()`` in ``edit/view.py`` references some attachment stuff. Is that still valid? delete\_media\_files() might use itervalues¶ -------------------------------------------- :: - for handle, listpath in media['media_files'].items(): + for listpath in media['media_files'].itervalues(): import export code: Use the init/ code¶ --------------------------------------- :: - setup_global_and_app_config(args.conf_file) + global_config, app_config = setup_global_and_app_config(args.conf_file) ... - config, validation_result = read_mediagoblin_config(args.conf_file) - connection, db = setup_connection_and_db_from_config( - config['mediagoblin'], use_pymongo=True) + connection, db = setup_connection_and_db_from_config(app_config, use_pymongo=True) final word¶ =========== These are UNTESTED suggestions to consider. They might break everything, be completely wrong, or just useful. Take your one and comment on it. Or create branch and add it here for merging.
Subtickets
Change History (7)
comment:2 Changed 11 years ago by
Okay, yet another small pick: ``submit/forms.py:SubmitStartForm`` and ``edit/forms.py:EditForm``: Both have a "``description``" field, which is untranslated. Please mark for translation.
comment:3 Changed 11 years ago by
Milestone: | → 0.1.0 |
---|
Marked description field for translation, pushed. Don't have time to look at the init stuff, I pass that off to someone else. Marking for 0.1.0.
comment:4 Changed 11 years ago by
Component: | → Programming |
---|---|
Owner: | set to Christopher Webber |
Status: | New → Feedback |
Refractored import\_export; `https://github.com/jwandborg/mediagoblin/tree/f536\_small\_code\_picks <https://github.com/jwandborg/mediagoblin/tree/f536_small_code_picks>`_ Please review and merge :)
comment:5 Changed 11 years ago by
Yet another... Needs translation: ``templates/mediagoblin/root.html``: - "Explore" - "Most recent media" And secondly, please take a look at: [https://gitorious.org/\ :sub:`elrond/mediagoblin/elronds-mediagoblin/commits/idea/use\_media\_url\_for\_self](https://gitorious.org/`\ elrond/mediagoblin/elronds-mediagoblin/commits/idea/use\_media\_url\_for\_self)
comment:6 Changed 11 years ago by
Status: | Feedback → Closed |
---|
Marked for translation. I guess that means this is closed (??)
comment:7 Changed 11 years ago by
The original url for this bug was http://bugs.foocorp.net/issues/536 .
Note: See
TracTickets for help on using
tickets.