Small code picks

[Elrond]

pre word¶
=========

While reviewing the late changes, I found some things, I would like
to be considered.

edit\_media() references attachments.¶
--------------------------------------

``edit_media()`` in ``edit/view.py`` references some attachment
stuff. Is that still valid?

delete\_media\_files() might use itervalues¶
--------------------------------------------

::

    - for handle, listpath in media['media_files'].items():
    + for listpath in media['media_files'].itervalues():

import export code: Use the init/ code¶
---------------------------------------

::

    - setup_global_and_app_config(args.conf_file)
    + global_config, app_config = setup_global_and_app_config(args.conf_file)
    ...
    - config, validation_result = read_mediagoblin_config(args.conf_file)
    - connection, db = setup_connection_and_db_from_config(
    -   config['mediagoblin'], use_pymongo=True)
    + connection, db = setup_connection_and_db_from_config(app_config, use_pymongo=True)

final word¶
===========

These are UNTESTED suggestions to consider. They might break
everything, be completely wrong, or just useful. Take your one and
comment on it. Or create branch and add it here for merging.

[Christopher Allan Webber]

-  edit\_media() references attachments: good point, removed.
-  delete\_media\_files itervalues stuff: good point, done.

Will look at the last one later.

[Elrond]

Okay, yet another small pick:

``submit/forms.py:SubmitStartForm`` and ``edit/forms.py:EditForm``:
Both have a "``description``" field, which is untranslated. Please
mark for translation.

[Christopher Allan Webber]

Marked description field for translation, pushed.

Don't have time to look at the init stuff, I pass that off to
someone else.

Marking for 0.1.0.

[joar]

Refractored import\_export;
`https://github.com/jwandborg/mediagoblin/tree/f536\_small\_code\_picks <https://github.com/jwandborg/mediagoblin/tree/f536_small_code_picks>`_

Please review and merge :)

[Elrond]

Yet another...

Needs translation:
``templates/mediagoblin/root.html``:


-  "Explore"
-  "Most recent media"

And secondly, please take a look at:
[https://gitorious.org/\ :sub:`elrond/mediagoblin/elronds-mediagoblin/commits/idea/use\_media\_url\_for\_self](https://gitorious.org/`\ elrond/mediagoblin/elronds-mediagoblin/commits/idea/use\_media\_url\_for\_self)

[Christopher Allan Webber]

Marked for translation. I guess that means this is closed (??)

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/536 .