Opened 15 years ago
Last modified 15 years ago
#225 closed defect (FIXED)
extra character shows up in pagination
| Reported by: | Caleb Davis | Owned by: | Chris Wilson |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.1.0 |
| Component: | ui | Keywords: | |
| Cc: | Parent Tickets: |
Description
See that dash after the arrow? I think I remember how Christopher fixed this in the last bug.
Change History (5)
comment:1 by , 15 years ago
comment:2 by , 15 years ago
I'm trying to think of the bug where Christopher fixed this in another case. Actually, IIRC all that will be needed is a change to the whitespace in the template code itself. I think that would fix both our issues.
comment:3 by , 15 years ago
ah, the git repository is easier to search - 132aa9d97a32abfe86bc5de3ea4e2fa62ddc3793
comment:4 by , 15 years ago
| Milestone: | → 0.1.0 |
|---|---|
| Owner: | set to |
| Status: | New → Closed |
Easy fix, pushed!
https://gitorious.org/mediagoblin/mediagoblin/commit/8775f68d33279347f7bc72258d9133f20b192149
What I do is set a variable to the generated url and then call it in two separate anchors. Jef is right... a larger hitbox that encompasses the whole thing would be better because then it would skip a "gap". For now, this is at least a fix from an underline mess.
Confirmed good sir! I was actually just about to report this. :)
Actually, at my side the whole thing is still underlined, including the arrow. No idea how that happened.
My question is this though... If we remove the little green/blue stripe that's in your screenshot, it will look like two floating elements, the "Older" link and the arrow image. You can click either of those, but not in between them. It would be preferable to have a hit target that's a single, large object that includes both of these elements. And if that's the case then we should also show it graphically (i.e. it looks the way it acts) for affordance reasons.
So I'm considering a bigger change here, but I am not sure what it should be.