Edit Profile: It should be possible to add Website-URLs without "http://"

[markus]

Currently, if you want to add a website-url to your profile, you have to include the string "​http://", otherwise you get an error stating "the url is in the wrong format". It should not be necessary to include "​http://" in the url.

[Ben Sturmfels]

I've attached a patch to allow people to not enter the http:// or https:// part of the website URL. If it's not provided, a prefix of http:// will be used.

Regards,
Ben

[ayleph]

Seems reasonable to me. If we're going to offer an explicit 'Website' box on the Edit Profile page, we might as well assume that a http(s) URI is going to be entered. CC'ing berker for review, and also cwebber in case he has any thoughts.

[berkerpeksag]

+ if not (data.startswith(u'​http://') or data.startswith(u'​https://')):

or if not data.startswith((u'http://', u'https://')):

Could you also pass a description parameter to WebsiteField to explain the new behavior? So people will notice that they don't have to write the http:// part.

Thanks!

[Ben Sturmfels]

Thanks Berker, I wasn't aware of that feature in startswith. I've also added a description with "www.example.com" to suggest that ​http:// part isn't required. What do you think?

[berkerpeksag]

Merged in ​http://git.savannah.gnu.org/cgit/mediagoblin.git/commit/?id=75dc254c651385a36feae38be416bffd322f4f07 and ​http://git.savannah.gnu.org/cgit/mediagoblin.git/commit/?id=2a1082e3dca62f6b8f2d543d5c49a5be0f35f030.

Thanks!

[Ben Sturmfels]

Hi Berker,

Thanks very much for merging this and also improving process_formdata to handle null/empty valuelist.

Unfortunately I think the other small tweak you made to the body broke the function for the case when there is already an http or https prefix, as shown in failing test test_edit.test_change_bio_url.

Patch attached.

Cheers,
Ben

[berkerpeksag]

Good catch, thanks! ​http://git.savannah.gnu.org/cgit/mediagoblin.git/commit/?id=17f5902a4cd87ca635f4de06ac8f541d13e40182