Double confirmation needed to delete media

[sebomoto]

When deleting a media item you have to first check a checkbox and then click then delete button.

This could be simplified by getting rid of the checkbox. Accidental media deletion should be prevented by the dialogue itself.

[Vijeth]

Remove checkbox prompt in the dialogue while deleting

[Vijeth]

Hi,

I thought it would be good to remove the checkbox while deleting the collection as well, just like for media.

I have attached a patch file for this, and also a screenshot to verify the working.

Thanks,
Vijeth

[Boris Bobrov]

Although the checkbox is hidden indeed, i am now getting "The media was not deleted because you didn't check that you were sure." :)

[Vijeth]

Oh I'm extremely sorry I totally forgot about the backend part :|
I think the revised patch should be fine?! I tested it, it gets deleted!

[Boris Bobrov]

Good!

2 things need fixing.

1. We have unit tests. They can be run with ./runtests.sh. With the change 1 test is failing -- TestSubmissionBasics.test_delete
2. While testing i found another place where this kind of checkbox is used -- removing an item from collection. Could you please fix it there too?

[Vijeth]

Revised patch including the backend part

[Vijeth]

Hi breton,

I'm so sorry for the inconvenience caused - I should have checked the tests.

I have applied the required changes and the test does not fail now! But, some of the tests in test_submission get skipped on my local machine. I don't know if this happened before so, can you check it out?

Thanks!