Opened 5 years ago

Last modified 3 years ago

#986 review enhancement

Double confirmation needed to delete media

Reported by: sebomoto Owned by:
Priority: minor Milestone:
Component: graphic design/interface Keywords: UX, UI, delete media file
Cc: Parent Tickets:

Description

When deleting a media item you have to first check a checkbox and then click then delete button.

This could be simplified by getting rid of the checkbox. Accidental media deletion should be prevented by the dialogue itself.

Subtickets

Attachments (3)

issue_986.patch (1.9 KB) - added by Vijeth 3 years ago.
Remove checkbox prompt in the dialogue while deleting
delete-ptompt-dialogue.png (84.5 KB) - added by Vijeth 3 years ago.
issue_986_rev.patch (10.2 KB) - added by Vijeth 3 years ago.
Revised patch including the backend part

Download all attachments as: .zip

Change History (12)

comment:1 Changed 5 years ago by sebomoto

Priority: majorminor

Changed 3 years ago by Vijeth

Attachment: issue_986.patch added

Remove checkbox prompt in the dialogue while deleting

comment:2 Changed 3 years ago by Vijeth

Status: newreview

Hi,

I thought it would be good to remove the checkbox while deleting the collection as well, just like for media.

I have attached a patch file for this, and also a screenshot to verify the working.

Thanks,
Vijeth

Changed 3 years ago by Vijeth

Attachment: delete-ptompt-dialogue.png added

comment:3 Changed 3 years ago by Boris Bobrov

Although the checkbox is hidden indeed, i am now getting "The media was not deleted because you didn't check that you were sure." :)

comment:4 Changed 3 years ago by Boris Bobrov

Status: reviewaccepted

comment:5 Changed 3 years ago by Vijeth

Status: acceptedreview

Oh I'm extremely sorry I totally forgot about the backend part :|
I think the revised patch should be fine?! I tested it, it gets deleted!

comment:6 Changed 3 years ago by Boris Bobrov

Good!

2 things need fixing.

  1. We have unit tests. They can be run with ./runtests.sh. With the change 1 test is failing -- TestSubmissionBasics.test_delete
  2. While testing i found another place where this kind of checkbox is used -- removing an item from collection. Could you please fix it there too?

comment:7 Changed 3 years ago by Boris Bobrov

Status: reviewaccepted

Changed 3 years ago by Vijeth

Attachment: issue_986_rev.patch added

Revised patch including the backend part

comment:8 Changed 3 years ago by Vijeth

Hi breton,

I'm so sorry for the inconvenience caused - I should have checked the tests.

I have applied the required changes and the test does not fail now! But, some of the tests in test_submission get skipped on my local machine. I don't know if this happened before so, can you check it out?

Thanks!

comment:9 Changed 3 years ago by Vijeth

Status: acceptedreview
Note: See TracTickets for help on using tickets.