Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#985 closed enhancement (fixed)

Misleading metadata processing log message

Reported by: Rodrigo Rodrigues da Silva Owned by:
Priority: trivial Milestone: 0.8.0
Component: programming Keywords:
Cc: Parent Tickets:

Description

After some medium is processed one gets the following message:

2014-10-17 10:24:05,320 DEBUG [mediagoblin.tools.processing] No processing callback for <MediaEntry 34: Aula1>

While developing/debugging a plugin I got this message and found it very confusing. Looking at the source code I'm convinced this message should read something like No metadata processing callback for <MediaEntry 34: Aula1>

Patch provided.

Subtickets

Attachments (1)

issue_985.patch (1.1 KB) - added by Rodrigo Rodrigues da Silva 7 years ago.

Download all attachments as: .zip

Change History (4)

Changed 7 years ago by Rodrigo Rodrigues da Silva

Attachment: issue_985.patch added

comment:1 Changed 7 years ago by Rodrigo Rodrigues da Silva

Status: newreview

comment:2 Changed 7 years ago by Christopher Allan Webber

Resolution: fixed
Status: reviewclosed

I agree, this message wasn't very clear. I merged your patch, then added a bit further clarification. "Processing Metadata" is a bit inconsistent with our later uses of the term metadata, but this happened before then. Basically this was just an indicator of whether or not there's a webhook to call.

Anyway, I adjusted the phrasing to:

        _log.debug('No processing callback URL for {0}'.format(entry))

and

    _log.debug('Sending processing callback for {0} to {1}'.format(
        entry,
        url))

That should be a lot clearer.

comment:3 Changed 7 years ago by Christopher Allan Webber

And thanks again! :)

Note: See TracTickets for help on using tickets.