unexpected behavior after submitting image

[Caleb Davis]

When I attempted to load this image - http://min.us/ldm9KG - I get an error:

Exception happened during processing of request from ('127.0.0.1', 49311) Traceback (most recent call last): File "/home/vfdc/src/mediagoblin/eggs/Paste-1.7.5.1-py2.6.egg/paste/httpserver.py", line 1068, in process_request_in_thread self.finish_request(request, client_address) File "/usr/lib/python2.6/SocketServer.py", line 320, in finish_request self.RequestHandlerClass(request, client_address, self) File "/usr/lib/python2.6/SocketServer.py", line 615, in init self.handle() File "/home/vfdc/src/mediagoblin/eggs/Paste-1.7.5.1-py2.6.egg/paste/httpserver.py", line 442, in handle BaseHTTPRequestHandler.handle(self) File "/usr/lib/python2.6/BaseHTTPServer.py", line 329, in handle self.handle_one_request() File "/home/vfdc/src/mediagoblin/eggs/Paste-1.7.5.1-py2.6.egg/paste/httpserver.py", line 437, in handle_one_request self.wsgi_execute() File "/home/vfdc/src/mediagoblin/eggs/Paste-1.7.5.1-py2.6.egg/paste/httpserver.py", line 287, in wsgi_execute self.wsgi_start_response) File "/home/vfdc/src/mediagoblin/eggs/Paste-1.7.5.1-py2.6.egg/paste/urlmap.py", line 203, in call return app(environ, start_response) File "/home/vfdc/src/mediagoblin/eggs/Beaker-1.5.4-py2.6.egg/beaker/middleware.py", line 152, in call return self.wrap_app(environ, session_start_response) File "/home/vfdc/src/mediagoblin/mediagoblin/app.py", line 115, in call return controller(request)(environ, start_response) File "/home/vfdc/src/mediagoblin/mediagoblin/decorators.py", line 50, in new_controller_func return controller(request, args, **kwargs)File "/home/vfdc/src/mediagoblin/mediagoblin/submit/views.py", line 79, in submit_startprocess_media_initial.delay(unicode(entry['_id']))File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/task/base.py", line 338, in delayreturn self.apply_async(args, kwargs)File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/task/base.py", line 436, in apply_asyncreturn self.apply(args, kwargs, task_id=task_id)File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/task/base.py", line 597, in applyretval = trace.execute()File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/execute/trace.py", line 76, in executeretval = self._trace()File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/execute/trace.py", line 86, in _tracepropagate=self.propagate)File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/execute/trace.py", line 34, in tracereturn cls(states.SUCCESS, retval=fun(*args,**kwargs))File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/task/base.py", line 241, in *call*return self.run(*args, **kwargs)File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/app/**init*.py", line 141, in runreturn fun(args,*kwargs) File "/home/vfdc/src/mediagoblin/mediagoblin/process_media/init.py", line 45, in process_media_initial thumb.save(thumb_file, "JPEG") File "/usr/lib/python2.6/dist-packages/PIL/Image.py", line 1439, in save save_handler(self, fp, filename) File "/usr/lib/python2.6/dist-packages/PIL/JpegImagePlugin.py", line 425, in _save raise IOError("cannot write mode %s as JPEG" % im.mode) IOError: cannot write mode P as JPEG

[Christopher Allan Webber]

http://www.velocityreviews.com/forums/t339757-convert-all-images-to-jpeg.html#post_message_1796370 looks like it has the answer..

[Caleb Davis]

Thanks, I made the suggested color mode checkpoint in mediagoblin/process_media/init.py

[Elrond]

Hi, can you post a patch or git tree, so this can be fixed until the great and wanted imagemagick rewrite is going to happen?

[Caleb Davis]

Hi, here's the commit on gitorious - [https://gitorious.org/_{cfdv/mediagoblin/cfdvs-mediagoblin/commit/f5ebb744e24c31a34ef953e73fac9512753887f8](https://gitorious.org/}cfdv/mediagoblin/cfdvs-mediagoblin/commit/f5ebb744e24c31a34ef953e73fac9512753887f8)

[Christopher Allan Webber]

Merged. Thanks Caleb!

In the future please put each feature in its own git branch so I can just merge it in and don't have to git cherry-pick.

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/377 .