Opened 14 years ago
Last modified 14 years ago
#90 closed defect (FIXED)
unexpected behavior after submitting image
| Reported by: | Caleb Davis | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.0.3 |
| Component: | programming | Keywords: | |
| Cc: | Parent Tickets: |
Description
When I attempted to load this image -
`http://min.us/ldm9KG <http://min.us/ldm9KG>`_ - I get an error:
Exception happened during processing of request from ('127.0.0.1',
49311)
Traceback (most recent call last):
File
"/home/vfdc/src/mediagoblin/eggs/Paste-1.7.5.1-py2.6.egg/paste/httpserver.py",
line 1068, in process\_request\_in\_thread
self.finish\_request(request, client\_address)
File "/usr/lib/python2.6/SocketServer.py", line 320, in
finish\_request
self.RequestHandlerClass(request, client\_address, self)
File "/usr/lib/python2.6/SocketServer.py", line 615, in *init*
self.handle()
File
"/home/vfdc/src/mediagoblin/eggs/Paste-1.7.5.1-py2.6.egg/paste/httpserver.py",
line 442, in handle
BaseHTTPRequestHandler.handle(self)
File "/usr/lib/python2.6/BaseHTTPServer.py", line 329, in handle
self.handle\_one\_request()
File
"/home/vfdc/src/mediagoblin/eggs/Paste-1.7.5.1-py2.6.egg/paste/httpserver.py",
line 437, in handle\_one\_request
self.wsgi\_execute()
File
"/home/vfdc/src/mediagoblin/eggs/Paste-1.7.5.1-py2.6.egg/paste/httpserver.py",
line 287, in wsgi\_execute
self.wsgi\_start\_response)
File
"/home/vfdc/src/mediagoblin/eggs/Paste-1.7.5.1-py2.6.egg/paste/urlmap.py",
line 203, in *call*
return app(environ, start\_response)
File
"/home/vfdc/src/mediagoblin/eggs/Beaker-1.5.4-py2.6.egg/beaker/middleware.py",
line 152, in *call*
return self.wrap\_app(environ, session\_start\_response)
File "/home/vfdc/src/mediagoblin/mediagoblin/app.py", line 115, in
*call*
return controller(request)(environ, start\_response)
File "/home/vfdc/src/mediagoblin/mediagoblin/decorators.py", line
50, in new\_controller\_func
return controller(request,
*args, **kwargs)File "/home/vfdc/src/mediagoblin/mediagoblin/submit/views.py", line 79, in submit\_startprocess\_media\_initial.delay(unicode(entry['\_id']))File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/task/base.py", line 338, in delayreturn self.apply\_async(args, kwargs)File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/task/base.py", line 436, in apply\_asyncreturn self.apply(args, kwargs, task\_id=task\_id)File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/task/base.py", line 597, in applyretval = trace.execute()File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/execute/trace.py", line 76, in executeretval = self.\_trace()File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/execute/trace.py", line 86, in \_tracepropagate=self.propagate)File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/execute/trace.py", line 34, in tracereturn cls(states.SUCCESS, retval=fun(\*args,**kwargs))File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/task/base.py", line 241, in *call*return self.run(*args,
**kwargs)File "/home/vfdc/src/mediagoblin/eggs/celery-2.2.6-py2.6.egg/celery/app/**init**.py", line 141, in runreturn fun(*args,*\*kwargs)
File
"/home/vfdc/src/mediagoblin/mediagoblin/process\_media/**init**.py",
line 45, in process\_media\_initial
thumb.save(thumb\_file, "JPEG")
File "/usr/lib/python2.6/dist-packages/PIL/Image.py", line 1439, in
save
save\_handler(self, fp, filename)
File "/usr/lib/python2.6/dist-packages/PIL/JpegImagePlugin.py",
line 425, in \_save
raise IOError("cannot write mode %s as JPEG" % im.mode)
IOError: cannot write mode P as JPEG
Change History (7)
comment:2 by , 14 years ago
Thanks, I made the suggested color mode checkpoint in mediagoblin/process\_media/**init**.py
comment:3 by , 14 years ago
| Component: | → Programming |
|---|---|
| Milestone: | → 0.0.3 |
| Status: | New → In Progress |
Hi, can you post a patch or git tree, so this can be fixed until the great and wanted imagemagick rewrite is going to happen?
comment:4 by , 14 years ago
Hi, here's the commit on gitorious - [https://gitorious.org/\ :sub:`cfdv/mediagoblin/cfdvs-mediagoblin/commit/f5ebb744e24c31a34ef953e73fac9512753887f8](https://gitorious.org/`\ cfdv/mediagoblin/cfdvs-mediagoblin/commit/f5ebb744e24c31a34ef953e73fac9512753887f8)
comment:5 by , 14 years ago
Merged. Thanks Caleb! In the future please put each feature in its own git branch so I can just merge it in and don't have to git cherry-pick.
comment:6 by , 14 years ago
| Status: | In Progress → Closed |
|---|
Note:
See TracTickets
for help on using tickets.
