Comments (simple)

[Christopher Allan Webber]

Comments to MediaEntry objects should be possible

I think we don't need to do complicated threading for now. Just comments which are paginated. Restricting to users registered on that site for now is good enough. We'll want more than that eventually, but for now it's okay.

• Just simple flat comments, no threading (yet)
• Just comments by logged in, active users
• pagination of comments! Sorted by comment time, obviously.
• Don't embed the comments, make the comments link back to the MediaEntries via their ObjectIds

That's it :)

[Christopher Allan Webber]

Also, comments should be formattable via markdown. However instead of rendering to html in the templates (which would be unnecessarily costly) we might as well render the body in the comment submission view like:

>>> comment['body'] = 'I am *soooo* hungry!'
>>> comment.render_body()
>>> comment['body_rendered']
u'<p>I am <em>soooo</em> hungry!</p>'
>>> comment.save()

[Christopher Allan Webber]

Don't forget to escape:

safe_mode="escape"

[http://www.freewisdom.org/projects/python-markdown/Using_as_a_Module](http://www.freewisdom.org/projects/python-markdown/Using_as_a_Module)

[joar]

Regarding markdown:

http://bugs.foocorp.net/issues/363#note-4

[Christopher Allan Webber]

Rumor is that Joar has done a small amount of work on this ;)

(Lies, Joar has done a lot of work!)

Joar, what's the status? Is there anything you think is missing presently, aside maybe from tests and indexing?

[joar]

Feature branch located at [https://gitorious.org/_{jwandborg/mediagoblin/jwandborgs-mediagoblin/commits/feature_362-simple_comments](https://gitorious.org/}jwandborg/mediagoblin/jwandborgs-mediagoblin/commits/feature_362-simple_comments), awaiting feedback.

[joar]

Changing % done, the remaining 20% is for feedback and necessary changes that emerges from said feedback.

[Christopher Allan Webber]

Merged! I'm willing to bypass tests before closing this ticket because we lack a good fixtures setup, but we do need to add indexing. I'll do that now.

[joar]

I've made even more changes, cleaning up the code structure as suggested by you and Elrond.

[https://gitorious.org/_{jwandborg/mediagoblin/jwandborgs-mediagoblin/commits/feature_362-simple_comments-acts_on_feedback](https://gitorious.org/}jwandborg/mediagoblin/jwandborgs-mediagoblin/commits/feature_362-simple_comments-acts_on_feedback)

[Christopher Allan Webber]

Closed! Merged your latest changes, and actually I pushed the indexing a bit ago...

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/362 .
Relations:
#337: related