Opened 10 years ago

Closed 9 years ago

#758 closed defect (fixed)

Fix skip_transcoding

Reported by: Beuc Owned by:
Priority: major Milestone: 0.7.0
Component: programming Keywords:
Cc: Beuc, Brett Smith Parent Tickets:

Description

Fix bad copy/paste in the code.

Subtickets

Attachments (2)

skip_transcoding.patch (875 bytes) - added by Beuc 10 years ago.
skip_transcoding_2.patch (874 bytes) - added by Brett Smith 9 years ago.
Typo-fix skip_transcoding.patch

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by Beuc

Attachment: skip_transcoding.patch added

comment:1 Changed 10 years ago by rodney757

Status: newreview

Changed 9 years ago by Brett Smith

Attachment: skip_transcoding_2.patch added

Typo-fix skip_transcoding.patch

comment:2 Changed 9 years ago by Brett Smith

I'm afraid the first attachment has a typo as well, using the config name in place of the metadata tag name. skip_transcoding_2.patch fixes that typo to make the function consistent with itself and other parts of the video module.

comment:3 Changed 9 years ago by Christopher Allan Webber

Cc: Beuc Brett Smith added

I've merged this... I trust Brett's review, and it looks right, though I have not tested it myself.

By the way Beuc, if you're still around, I'd love to put your name in these credits... at the moment I'll have to settle with "Beuc" unless you have something better! Let me know!

comment:4 Changed 9 years ago by Christopher Allan Webber

Milestone: 0.7.0
Resolution: fixed
Status: reviewclosed
Note: See TracTickets for help on using tickets.