Opened 7 years ago

Closed 7 years ago

#5532 closed enhancement (fixed)

Handle collection in batchaddmedia command

Reported by: simenheg Owned by:
Priority: minor Milestone:
Component: programming Keywords:
Cc: simenheg@… Parent Tickets:


The attached patch makes the batchaddmedia command look for a 'collection-slug' column, that for each row may specify the slug of a collection that the media should be added to. This matches the '--collection-slug' argument of the addmedia command.

Attachments (2)

issue_5532.patch (3.0 KB ) - added by simenheg 7 years ago.
issue_5532_rev2.patch (2.3 KB ) - added by simenheg 7 years ago.

Download all attachments as: .zip

Change History (5)

by simenheg, 7 years ago

Attachment: issue_5532.patch added

comment:1 by ayleph, 7 years ago

Status: newaccepted

Thanks for the patch, simenheg. Seems like a useful feature since we've added this for addmedia in a3c4802, as you mentioned.

I have one comment/request regarding the patch. It looks like there are some unrelated changes in the patch you provided. Can you remove those and submit a patch that only contains the changes related to adding media to a collection via the batchaddmedia command? If you found obsolete code that no longer does anything, I'd prefer to create a separate ticket for that. Thanks.

by simenheg, 7 years ago

Attachment: issue_5532_rev2.patch added

comment:2 by simenheg, 7 years ago

Cc: simenheg@… added; simenheg removed

Hi ayleph, thanks for your comments.

I've attached a patch with the cleanups removed. I'll provide a separate patch for them.

comment:3 by Boris Bobrov, 7 years ago

Owner: simenheg removed
Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.