Opened 7 years ago
Last modified 3 years ago
#5509 new defect
Video with lower dimensions gets transcoded to higher dimensions
| Reported by: | Vijeth | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.13.0 |
| Component: | programming | Keywords: | transcoding, video |
| Cc: | Boris Bobrov, alyph, thomzane | Parent Tickets: |
Description
I uploaded a video with (256, 144) dimensions, and changed the max default size (that a video can be transcoded to) to (1920, 1080). And, to my surprise, the video actually got transcoded to those dimensions.
So, when I viewed it on my local machine, there was zero padding (black colour) added to the top and bottom of the video to be in that resolution (dimensions).
These are the images:
I checked skip_transcode() method myself, and I realized the dimensionality check was working fine, but there was a problem with container-formats (not sure if it is a problem).
Basically, the video had 'ISO-MP4' container-format but mediagoblin config container-format string only allowed 'Matroska' container-format, and because of this the video was getting transcoded again (even though all other checks were fine).
Shall we remove this container-format check? Or add more container-formats to the config?
Change History (7)
comment:1 by , 7 years ago
comment:2 by , 5 years ago
| Cc: | removed |
|---|
Hi Vijeth,
Would you be willing to propose a patch to achieve the behavior you're expecting here?
Regards,
Ben
follow-up: 4 comment:3 by , 5 years ago
Hmm. I suspect that the issue tracker isn't sending email to the reporter by default. I'll look into this.
comment:4 by , 5 years ago
Replying to Ben Sturmfels:
Hmm. I suspect that the issue tracker isn't sending email to the reporter by default. I'll look into this.
Just confirming that the issues tracker has now been updated to send notifications to the reporter by default.
comment:6 by , 4 years ago
| Cc: | added |
|---|
Michael from FSF also reported that uploading an already encoded video triggered a transcode when he wasn't expecting it to. Not sure exactly what format that video was in when uploaded. Seems related to this issue though.
comment:7 by , 3 years ago
| Milestone: | 0.11.0 → 0.13.0 |
|---|
Why not leave the container format check as it is? That's a configuration option, so anyone can change it on their own instance. I think it's currently set to a reasonable default value. Maybe it would be good to document the video plugin options better so people know that they can change it.