Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#515 closed defect (fixed)

MediaGoblin makes thumbs 180px high, but css only allows 135px high max

Reported by: Christopher Allan Webber Owned by:
Priority: major Milestone: 0.4.0
Component: graphic design/interface Keywords:
Cc: Parent Tickets:

Description

MediaGoblin's default max_height for thumbs is 180px... from the config_spec:

[media:thumb]
# Dimensions used when creating media thumbnails
# This is unfortunately not implemented in the media
# types yet. You can help!
# TODO: Make plugins follow the media size settings
max_width = integer(default=180)
max_height = integer(default=180)

But MediaGoblin's CSS only allows for 135px high things!

.media_thumbnail img {
  max-height: 135px;
}

The end result? Weird squashed and grainy browser-resized thumbs.

One of these needs to change! But it's not currently just as simple as changing the max-height in the css, because that breaks the thumbs!

Subtickets

Change History (6)

comment:1 Changed 9 years ago by Christopher Allan Webber

The thumbs aren't really optimal in some other ways right now... descriptions are getting cut off... so addressing that when this is addressed maybe makes sense?

comment:2 Changed 9 years ago by Jef van Schendel

I propose we wait until we find the right thumbnail size.

Until that time let's resize via CSS. After we settle on a specific size, we can make a "real" change to the default thumbnail size.

comment:3 Changed 9 years ago by Christopher Allan Webber

Could we at least just remove the height restriction for now? CSS resizing makes our thumbs not look very nice.

comment:4 Changed 9 years ago by Elrond

+1 on removing it.

Resizing to 180 px images, then resizing those to 135 px via css... that's really ugly. Because there is no way for the browser to produce a nice 135 px view from only 180 px real size.

comment:5 Changed 9 years ago by Christopher Allan Webber

Milestone: 0.4.0
Owner: Jef van Schendel deleted
Resolution: fixed
Status: newclosed

Done and pushed in 0e4d6221fae26709d7ad32f40318df874b570bf8

comment:6 Changed 9 years ago by Christopher Allan Webber

For clarity, I commented out the CSS, with an explaination.

Note: See TracTickets for help on using tickets.