Opened 11 years ago

Closed 11 years ago

#447 closed enhancement (fixed)

A link to download the original audio file.

Reported by: Aleksej Owned by: Christopher Allan Webber
Priority: minor Milestone:
Component: programming Keywords: audio, sql, migration
Cc: deletesoftware@… Parent Tickets:

Description

Such a link is currently available for video, but not for audio.

Subtickets

Change History (7)

comment:1 Changed 11 years ago by Jakob Kramer

Keywords: bite-sized added
Owner: set to Jakob Kramer
Status: new → assigned

You can't use the “original” field of MediaEntrys, but an “ogg” field which holds the link equivalent to “original”… Maybe we should make a “migration” for that: change “ogg” to “original”?

​https://gitorious.org/~gandaro/mediagoblin/gandaros-mediagoblin/commits/audio-link-to-original

comment:2 Changed 11 years ago by joar

Keywords: audio sql migration added

We currently do not save the original file for audio.

I think we should

  • Add a configurable option to config_spec.ini such as 
    [media_type:mediagoblin.media_types.audio]
keep_original = boolean(default=True)
  • In audio.processing, keep the original file if the configuration setting is True (see the video media plugin)
  • Change the name of the ogg field to webm_audio.
  • Add download link to sidebar.

comment:3 Changed 11 years ago by Jakob Kramer

Keywords: bite-sized removed
  1. I think this is not bitesized anymore.
  2. It was the wrong tag name. ;)

comment:4 Changed 11 years ago by Jakob Kramer

Okay, I am done with it. ​Merge request

comment:5 Changed 11 years ago by joar

Owner: changed from Jakob Kramer to Christopher Allan Webber

I've looked at it. It seems fine and tests pass except for metadata table errors that we usually see due to nosetest's generous module imports.

comment:6 Changed 11 years ago by joar

Merged!

comment:7 Changed 11 years ago by joar

Resolution: → fixed
Status: assigned → closed
Note: See TracTickets for help on using tickets.