Opened 13 years ago
Closed 12 years ago
#410 closed enhancement (fixed)
Move full OpenStreetMap, Leaflet & Mapquest-copyright text from the map widget
Reported by: | joar | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 0.3.2 |
Component: | graphic design/interface | Keywords: | |
Cc: | Jef van Schendel | Parent Tickets: |
Description
Currently the copyright text takes up exactly 25% of the maps viewport.
We should probably do it the foursquare way (https://foursquare.com/v/electrolux-group-hq/4b224d3ef964a5204b4524e3) and put a single link in there that will show you the full license notice.
So either we
- Show the content dynamically with JavaScript
- Set up a new page with the license info (general license info page?), which we link to from the map widget. <- Yay for this one!
Change History (8)
comment:1 by , 12 years ago
Milestone: | 0.3.0 → 0.3.1 |
---|
comment:2 by , 12 years ago
comment:3 by , 12 years ago
Owner: | removed |
---|---|
Status: | new → assigned |
comment:4 by , 12 years ago
Component: | component1 → graphic design/interface |
---|
comment:5 by , 12 years ago
Milestone: | 0.3.1 |
---|
This didn't make it into 0.3.1.
If someone is interested in working on this for 0.3.2, please assign yourself and move the issue to the 0.3.2 milestone.
comment:6 by , 12 years ago
Milestone: | → 0.3.3 |
---|
I have had a cut at this. This also takes care of issue #514 (incorrect OSM license)
See branch 410_OSM_attrib at my git repo git://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin.git
Screenshot with the relevant excerpts is here: http://farm9.staticflickr.com/8349/8184591265_cc17709aef_b.jpg
Commit description:
Place OpenStreetMap license into footer (#410)
1) Only a short blurb "see map license" in the small map which links
to the full license blurb that will be displayed in the footer of
the page. The full blurb will dynamically be inserted via jquery
when needed. Adapt the OpenStreetMap text as advized in
http://www.openstreetmap.org/copyright and link there.
2) Place the geolocation_visible setting (defaults to false) in
mediagoblin.ini to make it more discoverable. I'd vote for a default
of true.
NOTE: the license blurb still says ©mapquest for imagery when we don't
use mapquest. This still needs discussion/clarification.
The disadvantage is that this only works when Javascript is enabled,
but as the map only works when Javascript is enabled in the first place,
this should not be too much of a limitation.
comment:7 by , 12 years ago
Branch and patch from last comment has been superseded by my branch 410_OSM_attrib_v2 in the same repo. Rather than bloating the footer with lines and lines of license text, this will slide out the full license text via jquery when clicked in the map.
comment:8 by , 12 years ago
Milestone: | 0.3.3 → 0.3.2 |
---|---|
Resolution: | → fixed |
Status: | new → closed |
This looks great. I've merged it!
I think the general license info page is the right way to go. I've actually been thinking increasingly that it might make sense at the bottom of the page that links to source and license details in one big comprehensive place, including all license information for plugins?
That would be a big undertaking though and would need its own ticket. Schendje, do you have any thoughts?