Opened 12 years ago

Closed 12 years ago

#390 closed defect (fixed)

"Separate tags by commas" should be unnecessary

Reported by: Jef van Schendel Owned by: spaetz
Priority: minor Milestone: 0.3.2
Component: programming Keywords: bitesized
Cc: sebastian@… Parent Tickets:


I think JanCBorchardt talked about this before. This text really shouldn't be necessary.

We should choose one method and stick with it. The user should be able to enter tags as desired, after which they will automatically be seperated.

Change History (13)

comment:1 by joar, 12 years ago

I like the expliicit comma separation of tags, it enables me to have tags that are more verbose, like "georgia 2011" or "dj spyhunter".

comment:2 by Will Kahn-Greene, 12 years ago

Milestone: 0.2.1

Bumping this out of 0.2.1. If someone wants to grab it, feel free to grab it and put it in 0.2.2.

comment:3 by Christopher Allan Webber, 12 years ago

Component: component1programming

comment:4 by joar, 12 years ago

Disregard my previous comment, the "Verbose names" should be handled by "sets" or "albums" not tags.

comment:5 by Jakob Kramer, 12 years ago

Priority: blockerminor

comment:6 by Christopher Allan Webber, 12 years ago

Keywords: bitesized added

I feel pretty strongly that we should keep comma separated tags.

The code mostly only provides one of these options, but there's some leftover crufty code in mediagoblin/tools/ that provides the option of a delimiter.. we should remove that and make it explicitly a comma. That's an easy task.. marking this as bitesized.

comment:7 by ShawnRisk, 12 years ago

Owner: somebody removed
Status: newassigned

comment:8 by Aleksej, 12 years ago

Some new users enter tags like “#tag1 #tag2 #tag3”, despite the text.

Version 0, edited 12 years ago by Aleksej (next)

comment:9 by Duncan, 12 years ago

Fixed comma delimiter to fixed delimiter as per "comment 6". Changed some text formatting to fit pep8

branch is 390_delim

comment:10 by spaetz, 12 years ago

Cc: sebastian@… added
Keywords: needsreview added
Milestone: 0.3.3
Owner: set to spaetz
Status: newassigned

I'll see if I can review this durin this week.

comment:11 by spaetz, 12 years ago

I reviewed dunkyp's patch and it is exactly the right thing to do. The only thing I have done is to squash the patches/reverts and incremental improvements into a single patch by him, they touch only a few lines.

I also added a second cosmetic patch on top that get's rid of 2 more lines.
Branch can be seen here:

Please merge branch 390_delim of my git repo at git://

comment:12 by spaetz, 12 years ago

Keywords: needsreview removed

comment:13 by Elrond, 12 years ago

Resolution: fixed
Status: assignedclosed

Merged spaetz' branch.

Commit: fa2f6ba162

Note: See TracTickets for help on using tickets.