Opened 11 years ago
Closed 10 years ago
#390 closed defect (fixed)
"Separate tags by commas" should be unnecessary
Reported by: | Jef van Schendel | Owned by: | spaetz |
---|---|---|---|
Priority: | minor | Milestone: | 0.3.2 |
Component: | programming | Keywords: | bitesized |
Cc: | sebastian@… | Parent Tickets: |
Description
I think JanCBorchardt talked about this before. This text really shouldn't be necessary.
We should choose one method and stick with it. The user should be able to enter tags as desired, after which they will automatically be seperated.
Subtickets
Change History (13)
comment:1 Changed 11 years ago by
comment:2 Changed 11 years ago by
Milestone: | 0.2.1 |
---|
Bumping this out of 0.2.1. If someone wants to grab it, feel free to grab it and put it in 0.2.2.
comment:3 Changed 11 years ago by
Component: | component1 → programming |
---|
comment:4 Changed 11 years ago by
Disregard my previous comment, the "Verbose names" should be handled by "sets" or "albums" not tags.
comment:5 Changed 11 years ago by
Priority: | blocker → minor |
---|
comment:6 Changed 11 years ago by
Keywords: | bitesized added |
---|
I feel pretty strongly that we should keep comma separated tags.
The code mostly only provides one of these options, but there's some leftover crufty code in mediagoblin/tools/text.py that provides the option of a delimiter.. we should remove that and make it explicitly a comma. That's an easy task.. marking this as bitesized.
comment:7 Changed 11 years ago by
Owner: | somebody deleted |
---|---|
Status: | new → assigned |
comment:8 Changed 10 years ago by
Some new users enter tags as “#tag1 #tag2 #tag3”, despite the text. Maybe an example would work better for them?
comment:9 Changed 10 years ago by
Fixed comma delimiter to fixed delimiter as per "comment 6". Changed some text formatting to fit pep8
https://gitorious.org/~dunkyp/mediagoblin/dunkyps-mediagoblin
branch is 390_delim
comment:10 Changed 10 years ago by
Cc: | sebastian@… added |
---|---|
Keywords: | needsreview added |
Milestone: | → 0.3.3 |
Owner: | set to spaetz |
Status: | new → assigned |
I'll see if I can review this durin this week.
comment:11 Changed 10 years ago by
I reviewed dunkyp's patch and it is exactly the right thing to do. The only thing I have done is to squash the patches/reverts and incremental improvements into a single patch by him, they touch only a few lines.
I also added a second cosmetic patch on top that get's rid of 2 more lines.
Branch can be seen here: https://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin/commits/390_delim
Please merge branch 390_delim of my git repo at git://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin.git
comment:12 Changed 10 years ago by
Keywords: | needsreview removed |
---|
comment:13 Changed 10 years ago by
Milestone: | 0.3.3 → 0.3.2 |
---|---|
Resolution: | → fixed |
Status: | assigned → closed |
Merged spaetz' branch.
Commit: fa2f6ba162
I like the expliicit comma separation of tags, it enables me to have tags that are more verbose, like "georgia 2011" or "dj spyhunter".