atom feed not valid

[Michele Azzolari]

ATOM feed is not valid, entry id must be an URL

http://validator.w3.org/feed/check.cgi?url=http%3A%2F%2Fmediagoblin.com%2Fu%2Felrond%2Fatom%2F

[Michele Azzolari]

issue_724.patch

[Michele Azzolari]

I made a few changes to fix the id bug and then I added some more infos to the atom (author uri and links to the html version)

[Elrond]

Hi,

I have looked over the patch!

Looks mostly good.

Just two things I wonder:

1. The "url=" from the AtomFeed isn't needed any more, because the new links thing does all the needed stuff?
2. This 2011 looks very suspicious? What is it doing there?

[Christopher Allan Webber]

Yes, I'd like to merge this ASAP... however I'm not sure what's going on here:

id='tag:%s,' + request.host + ',2011:UserGallery:' + request.matchdict['user'],

What is this?

Also, your code is good, but it would be good if it followed the style of the rest of our code, which follows PEP-8:

http://www.python.org/dev/peps/pep-0008/

For example:

--- a/mediagoblin/listings/views.py
+++ b/mediagoblin/listings/views.py
@@ -81,14 +81,25 @@ def tag_atom_feed(request):
         "MediaGoblin: Feed for tag '%s'" % tag_slug,
         feed_url=request.url,
         id='tag:'+request.host+',2011:TagGallery:%s' % tag_slug,
-        links=[{'href': request.urlgen('mediagoblin.listings.tags_listing', qualified=True,tag=tag_slug ), 'rel': 'alternate','type': 'text/html'}])
+        links=[{'href': request.urlgen(
+                    'mediagoblin.listings.tags_listing',
+                    qualified=True,tag=tag_slug ),
+                'rel': 'alternate',
+                'type': 'text/html'}])
     for entry in cursor:
-        feed.add(entry.get('title'),
+        feed.add(
+            entry.get('title'),
             entry.get('description_html'),
             content_type='html',
-            author={'name': entry.get_uploader.username,'uri': request.urlgen('mediagoblin.user_pages.user_home', qualified=True, user=entry.get_uploader.username)},
+            author={
+                'name': entry.get_uploader.username,
+                'uri': request.urlgen(
+                    'mediagoblin.user_pages.user_home',
+                    qualified=True, user=entry.get_uploader.username)},
             updated=entry.get('created'),
-            links=[{'href':entry.url_for_self(request.urlgen,qualified=True), 'rel': 'alternate','type': 'text/html'}],
+            links=[
+                {'href': entry.url_for_self(request.urlgen,qualified=True),
+                 'rel': 'alternate','type': 'text/html'}],
             url=entry.url_for_self(request.urlgen, qualified=True))

     return feed.get_response()

Breaking those lines up and doing spacing like above really helps code be a lot easier to read!

Bumping priority up to "high".

[Michele Azzolari]

The ATOM id is a tag URI [1][2]

The year I choose is when the mediagoblin project started (blogger uses 1999 for example)

Sorry about my code style, I'll try to follow PEP-8 in future (I'm not really into python so please help me if I do it wrong)

[1] http://en.wikipedia.org/wiki/Tag_URI [2] http://www.intertwingly.net/wiki/pie/IdElement?action=highlight&value=tag%3A

[Michele Azzolari]

issue_724.patch.gz

[Michele Azzolari]

Ok, it should be fine now.

Let me know

[Christopher Allan Webber]

Merged! Thanks!

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/724 .