Inform people they need a better browser if missing <video>, webm

[Christopher Allan Webber]

We should add some messaging for people to know that they should get a better browser if or webm is not enabled.

We could use http://www.modernizr.com/ to detect this.

[Inconexo ø]

Is modernizr needed or yepnope is enough? ( http://yepnopejs.com/ ).

I have done a quick research and found that yepnope is the part of modernizr that allows to see if a browser feature is available or not. Modernizr is much bigger and provides replacement to make those features work (at a cost).

[Christopher Allan Webber]

Oh hey Inconexo, great research! Yes, we don't need the whole bulk of modernizr if that's the case, just the detection part. If yepnope provides that subset, then we should just use yepnope for now.

Thanks!

[Karen Rustad]

Currently working on this bug, using yepnope :)

[Karen Rustad]

0001-Added-a-you-don-t-have-HTML5-so-this-video-will-not-.patch

[Karen Rustad]

As far as I could tell, the way we wanted to use it, Modernizr was a dependency of yepnope anyway! And neither were behaving the way that their documentation said they should, grr. I was able to get a JS version of the warning working, though.

But then... Actually, http://fortuito.us/diveintohtml5/video.html#ie and http://camendesign.com/code/video_for_everybody suggest that because of how the tag is designed, we don't actually need any fancy html5 detection or javascript at all! We just put our warning inside the video tag, after any and all s, and browsers that don't understand this html5 nonsense will happily show our warning to the world.

Besides having less js to load and run, this implementation also makes it super easy to translate our warning (whereas before, the warning text was inside the js file, where i18n couldn't touch it!).

Here's a patch that implements the javascript-less version of this feature. I tested it in Lynx and got the desired behavior; others should test it in other old-fashioned browsers!

[Elrond]

Merged! Thanks!

Thanks to Chris for reminding to use "git am"!

Bonus points to earn: Translation tags around the text, and making things fit within 80 columns.

You could change the bug status to "Feedback", that might help find issues with mergeable patches.

[Karen Rustad]

0001-added-translation-tags-to-html5-wwarning.patch

[Karen Rustad]

Here's an additional patch with translation tags and (I think) 80-char column compatibility (unfortunately my text editor doesn't make setting the # of columns easy...)

[Elrond]

Applied (using git am)!

Thanks a lot!

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/686 .