Opened 9 years ago

Last modified 9 years ago

#329 closed defect (FIXED)

Drop custom delimiters in tags

Reported by: Christopher Allan Webber Owned by: Manolinux aka Mu
Priority: minor Milestone: 0.2.0
Component: programming Keywords:
Cc: Parent Tickets:

Description

As we agreed on IRC a long time ago, custom delimiters are too
complex for translation and other reasons. We might be able to
think of a nice way to implement them but at this point it's too
much of a mess.

Switch the tag delimiter to comma only.



Subtickets

Change History (7)

comment:1 Changed 9 years ago by maiki interi

By custom delimiters, do you mean using both commas and spaces, or
is there something additional that can be configured? I ask,
because I was going to report that spaces don't separate tags,
which is great, because I tag people by name, and not *all* of my
friends are
`mononymous <https://en.wikipedia.org/wiki/Mononymous_person>`_.
=]

Currently, the description copy is
``Seperate tags by commas or spaces.`` Should probably just be
``Separate tags with commas``.

Same issue?



comment:2 Changed 9 years ago by Manolinux aka Mu

I pushed the fix to my repository:
`git@gitorious.org <mailto:git@gitorious.org>`_:~manolinux/mediagoblin/manolinuxs-mediagoblin.git

Finally I defined a constant in the same text.py.

I removed a test that tested a feature related with custom tags
delimiter.

I also took care of
`http://bugs.foocorp.net/issues/671 <http://bugs.foocorp.net/issues/671>`_



comment:3 Changed 9 years ago by Manolinux aka Mu

maiki interi wrote:

    By custom delimiters, do you mean using both commas and spaces, or
    is there something additional that can be configured? I ask,
    because I was going to report that spaces don't separate tags,
    which is great, because I tag people by name, and not *all* of my
    friends are
    `mononymous <https://en.wikipedia.org/wiki/Mononymous_person>`_.
    =]

    Currently, the description copy is
    ``Seperate tags by commas or spaces.`` Should probably just be
    ``Separate tags with commas``.

    Same issue?


Indeed, tags are not separated by spaces since long time, the
message is wrong and must be updated. I am going to do right now,
but I think I will open a new issue.



comment:4 Changed 9 years ago by Manolinux aka Mu

Owner: set to Manolinux aka Mu

comment:4 Changed 9 years ago by Manolinux aka Mu

Status: NewFeedback
The branch for this is also 671\_spaces\_in\_tag\_list\_edit ,
since it was more practical to make the two things at the same
time, and I don't think seperately would work.



comment:5 Changed 9 years ago by Elrond

Status: FeedbackClosed
Merged.
Thanks!



comment:6 Changed 9 years ago by Will Kahn-Greene

The original url for this bug was http://bugs.foocorp.net/issues/678 .
Relations:
#323: related

Note: See TracTickets for help on using tickets.