Opened 12 years ago

Last modified 9 years ago

#323 closed defect (FIXED)

Tags list on Edit page is not seperated by spaces and hard to read

Reported by: Jef van Schendel Owned by: Manolinux aka Mu
Priority: minor Milestone: 0.2.0
Component: programming Keywords:
Cc: Parent Tickets:


On the Edit page for any media, the "Tags" field look like this, no
matter if you used commas, spaces or both:



Instead, it could use some space between the tags to make it more


    tag1, tag2, tag3, tag4

I've also changed the tag list on media pages to "Tagged with tag1,
tag2, tag3, etc", so if we change this they will be consistent in

Change History (8)

comment:1 by Manolinux aka Mu, 12 years ago

It is easy to add a whitespace:


    -        media_tag_string = mg_globals.app_config['tags_delimiter'].join(
    +        media_tag_string = (mg_globals.app_config['tags_delimiter']+u' ').join(
                                           [tag['name'] for tag in media_entry_tags])

but I am unsure about something.

'tags\_delimeter' is parametrized but, do you want to make the
whitespace "hardcoded"? I think it is ok, but I want to be sure.

comment:2 by Christopher Allan Webber, 12 years ago

You're right mano, shouldn't be too hard.

However I think we agreed on IRC that we were going to drop the
custom-delimiters. I marked `#678 </issues/678>`_ as related.
Someone interested could probably wrap these up in one simple swoop
by doing ', '.join() instead and removing the custom delimiter

comment:3 by Manolinux aka Mu, 12 years ago

That would be easy because I think 'tags\_delimiter' is only used
twice in all code.

But, are you sure you want to put only ', ', it is similar to a
magic number. Suppose you want to change the delimiter tomorrow,
you would need to search for commas inside the code (madness)
instead of searching for tags\_delimiter, wich would be more

Maybe we could use a constant if you don't want it to be

Anyway, could you please assign this bug to me?

comment:4 by Elrond, 12 years ago

Owner: set to Manolinux aka Mu
Added you as Hacker,Reporter so that we (and you yourself) can
assign you to some issues.
And assigned this issue to you.

comment:5 by Manolinux aka Mu, 12 years ago

Status: NewIn Progress
I pushed the fix to my repository:
` <>`_:~manolinux/mediagoblin/manolinuxs-mediagoblin.git

Finally I defined a constant in the same

I modified a test that expected the tags as 'yin,yang' instead of
'yin, yang'.

I also took care of
` <>`_

comment:6 by Manolinux aka Mu, 12 years ago

Status: In ProgressFeedback
I forgot to say the branch name is

comment:7 by Elrond, 12 years ago

Milestone: 0.2.0
Status: FeedbackClosed

comment:8 by Will Kahn-Greene, 12 years ago

The original url for this bug was .
#329: related

Note: See TracTickets for help on using tickets.