Opened 13 years ago

Last modified 13 years ago

#305 closed defect (FIXED)

Getting unwarranted exceptions (from CSRF code) when crawled by GoogleBot & friends

Reported by: Christopher Allan Webber Owned by: nyergler
Priority: minor Milestone: 0.2.0
Component: programming Keywords:
Cc: Parent Tickets:

Description 

Errors are like so:

::

    Error - <type 'exceptions.AttributeError'>: 'BaseResponse' object has no attribute 'vary'
    URL: http://mediagoblin.com/tag/barcelona/atom/
    File '/srv/mediagoblin.com/lib/python2.6/site-packages/Paste-1.7.5.1-py2.6.egg/paste/exceptions/errormiddleware.py', line 144 in __call__
      app_iter = self.application(environ, sr_checker)
    File '/srv/mediagoblin.com/lib/python2.6/site-packages/Beaker-1.6.1-py2.6.egg/beaker/middleware.py', line 155 in __call__
      return self.wrap_app(environ, session_start_response)
    File '/srv/mediagoblin.com/src/mediagoblin/mediagoblin/app.py', line 175 in __call__
      m.process_response(request, response)
    File '/srv/mediagoblin.com/src/mediagoblin/mediagoblin/middleware/csrf.py', line 101 in process_response
      response.vary = (response.vary or []) + ['Cookie']
    AttributeError: 'BaseResponse' object has no attribute 'vary'

It looks like there is no response.vary, which is what is causing
this error...

Change History (3)

comment:1 by nyergler, 13 years ago

Status: New → Resolved 
This is resolved with Merge Request 30.

`https://gitorious.org/mediagoblin/mediagoblin/merge\_requests/30 <https://gitorious.org/mediagoblin/mediagoblin/merge_requests/30>`_

comment:2 by Christopher Allan Webber, 13 years ago

Status: Resolved → Closed 
Merged. Thanks!

comment:3 by Will Kahn-Greene, 13 years ago

The original url for this bug was ​http://bugs.foocorp.net/issues/653 .

Note: See TracTickets for help on using tickets.