MediaGoblin broken by recent WebOb release

[Christopher Allan Webber]

URL: http://127.0.0.1:6543/favicon.ico
File '/home/cwebber/devel/mediagoblin/lib/python2.6/site-packages/Paste-1.7.5.1-py2.6.egg/paste/exceptions/errormiddleware.py', line 144 in __call__
  app_iter = self.application(environ, sr_checker)
File '/home/cwebber/devel/mediagoblin/lib/python2.6/site-packages/Paste-1.7.5.1-py2.6.egg/paste/urlmap.py', line 203 in __call__
  return app(environ, start_response)
File '/home/cwebber/devel/mediagoblin/lib/python2.6/site-packages/Beaker-1.5.4-py2.6.egg/beaker/middleware.py', line 152 in __call__
  return self.wrap_app(environ, session_start_response)
File '/home/cwebber/devel/mediagoblin/mediagoblin/app.py', line 140 in __call__
  request.locale = translate.get_locale_from_request(request)
File '/home/cwebber/devel/mediagoblin/mediagoblin/tools/translate.py', line 68 in get_locale_from_request
  accept_lang_matches = request.accept_language.best_matches()
AttributeError: 'AcceptLanguage' object has no attribute 'best_matches'

http://docs.webob.org/en/latest/news.html

Looks like this is what caused it:

"Accept.best_matches() is gone; use list(request.accept) or request.accept.best_match(..) instead (applies to all Accept-* headers) or similar with request.accept_language."

[Christopher Allan Webber]

Fixed, and pushed said fix.

[Christopher Allan Webber]

I'm re-opening this.

The tests are still broken... WebOb is broken if you don't pass in a language in the header.

I'm submitting a patch to WebOb... in the meanwhile we should target at an older WebOb as a stopgap fix.

[Christopher Allan Webber]

Submitted and got a patch merged: https://github.com/Pylons/webob/issues/5

And pushed a version requirement as a temporary fix.

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/622 .