Improve cache friendliness of static content

[Elrond]

If not serving the (semi-)static content (css etc and the media items) through a dedicated webserver but using paste#static the caching is bad.

It could easily be argued, that on a real deployment, these tings should be served by a dedicated webserver. But still, the paste based setups should give reasonable caching.

There are two items to consider:

1. mediagoblin/mgoblin_static/ (CSS, ...)

Only layout/etc developers will change this and those will likely use "reload" on their browsers anyway. Everybody else will only change this when updating their install. So even thinking about people updating and wanting a fresh look soon, at least an hour would be good. I'd rather suggest a day.

2. media content (public_store)

media items aren't modified currently. They get written once and stay there as written. Creating a new media entry, creates a new object id, etc. I'd say a week is good.

[Elrond]

So how to implement this? Simple.

And thinking again about it, I'd suggest a day for the css/etc stuff.

--- a/paste.ini
+++ b/paste.ini
@@ -19,10 +19,12 @@ config = %(here)s/mediagoblin.ini
 [app:publicstore_serve]
 use = egg:Paste#static
 document_root = %(here)s/user_dev/media/public/
+cache_max_age = 604800

 [app:mediagoblin_static]
 use = egg:Paste#static
 document_root = %(here)s/mediagoblin/static/
+cache_max_age = 86400

 [filter:beaker]
 use = egg:Beaker#beaker_session

[Elrond]

I'll happily push a branch, if someone wants me to.

[Christopher Allan Webber]

Hm. I have a pretty significant concern with this, and that's memory bloat. Imagine you're serving a .webm file... wouldn't that bloat your memory keeping that cached really fast? What if you're serving 10? ;)

I do think it's best that we serve this stuff through apache and etc... I do also agree that a lot of people won't configure things right from the get-go, and so we should provide sane defaults.

How about a compromise... we keep commented-out versions of those options in the file, with a comment above them explaining "uncomment these to enable simple python-side caching"?

[Elrond]

These options do not affect memory on the server(!) in any way. They affect cache on the client. They tell the client: The content it just received will not change in the next N seconds. Nothing more, nothing less. Client decides how to use this info. Clients usually cache this stuff and decide not to ask the server over and over again for the same file. Good. Saves network bandwidth.

Over simplifications used above: 1. The config will take a few bytes of ram on the server. 2. I'd guess, proxy servers are allowed to cache too.

[Elrond]

Talked to chris. We'll do like I suggested. I'll push a branch (assigned to me for that reason).

[Elrond]

New branch: misc/f602_client_cache_improvement

[Christopher Allan Webber]

Merged!

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/602 .