Opened 11 years ago

Last modified 11 years ago

#250 closed defect (FIXED)

Comment links uses media._id instead of media.slug in the URL

Reported by: joar Owned by: Larisa Hoffenbecker
Priority: minor Milestone: 0.2.0
Component: programming Keywords:
Cc: Parent Tickets:

Description

It should be changed so that comment URLs are

::

    /u/{username}/m/{slug}/c/{comment_id}/#comment instead of   
    /u/{username}/m/{media_id}/c/{comment_id}/#comment



Subtickets

Change History (8)

comment:1 Changed 11 years ago by Christopher Allan Webber

Owner: set to Larisa Hoffenbecker
Assigning to Larissa!



comment:2 Changed 11 years ago by joar

I noticed the edit\_media view does this too;
`http://mg.jwandborg.pagekite.me/u/joar/m/4e6a69d5d9d7837042000004/edit/ <http://mg.jwandborg.pagekite.me/u/joar/m/4e6a69d5d9d7837042000004/edit/>`_
(Although you can't access it).



comment:3 Changed 11 years ago by joar

Same thing with the add\_attachment view. Those should also use
slugs in stead of IDs.

Ping me on IRC/update this issue if there's any questions.



comment:4 Changed 11 years ago by Christopher Allan Webber

Milestone: 0.1.00.2.0

comment:4 Changed 11 years ago by Jakob Kramer

Are you still working on this bug, Larisa? If not, I would like to
resolve this bug. Thank you!



comment:5 Changed 11 years ago by Christopher Allan Webber

Hey Jakob Kramer,

I appreciate you jumping on this :)

Larisa said she finished this task but she's new to git, could give
me the diff now, but said otherwise she'll try to push it up to the
repository this weekend. I encouraged her to try to push it up to
git this weekend because I think it's good for contributors to
learn how to use git properly. If you feel strongly that this
should be done sooner, I can ask for a patch. Otherwise, let's just
wait till the weekend!



comment:6 Changed 11 years ago by Christopher Allan Webber

Status: NewClosed
Larisa pushed a branch:

[https://gitorious.org/\ :sub:`lorochka85/mediagoblin/lorochka85s-mediagoblin](https://gitorious.org/`\ lorochka85/mediagoblin/lorochka85s-mediagoblin)

And I just merged it. Just in time for 0.2.0!

Thanks Larisa!



comment:7 Changed 11 years ago by Will Kahn-Greene

The original url for this bug was http://bugs.foocorp.net/issues/582 .

Note: See TracTickets for help on using tickets.