Opened 13 years ago

Closed 12 years ago

#243 closed defect (wontfix)

Add minimized exception to javascript headers when we start adding them :)

Reported by: Christopher Allan Webber Owned by:
Priority: critical Milestone: 0.3.0
Component: programming Keywords:
Cc: Parent Tickets:

Description (last modified by Christopher Allan Webber)

See the bottom of:

` <>`_

I don't want to make minimizing javascript not-okay. When we add
our first javascript code, we should add a version of this

Change History (12)

comment:1 by Christopher Allan Webber, 13 years ago

er, I want to make it okay! not-not-okay. :) edit: I used a double
negative the first time, so it was correct.

comment:2 by Christopher Allan Webber, 12 years ago


comment:3 by Christopher Allan Webber, 12 years ago


comment:2 by Christopher Allan Webber, 12 years ago

See the bottom of:
` <>`_

comment:3 by Christopher Allan Webber, 12 years ago

Priority: NormalUrgent

comment:3 by Elrond, 12 years ago

Component: InfrastructureProgramming
This is a "we should not forget X when starting to use js" bug.

Jef started to use js, so this is getting relevant!

Chris, can you elaborate, what exactly we have to do?
We probably need to modify ``static/js/show_password.js``?

We hopefully don't have to modify our shipped version of jquery.
That would be a maintainance nightmare!

comment:4 by Christopher Allan Webber, 12 years ago

All we have to do is to add the minimized javascript exception at
the bottom of the forementioned link to all our javascript
headers, below the normal AGPL headers. Only ours though, not

I **think** we might also need to do this to the python side, but
that part I'm not sure about. The trouble with that is that it
would mean having to possibly get permission from **all** python
committers. That's a lot of people to contact. I don't think we
even **can** contact all translators.

Someone should set the javascript headers to include the exception.
I'll ping Brett again to see how serious adding the exception to
everything else is.

comment:5 by Will Kahn-Greene, 12 years ago

The original url for this bug was .
#360: blocked

comment:6 by Christopher Allan Webber, 12 years ago

I think I've spent all my pester-Brett-Smith points for a few months. In the meanwhile though we could take some action on this ticket by including the AGPL license in the same directory as the javascript files we provide. We're possibly not really doing things right by not doing so now.

comment:7 by Elrond, 12 years ago


We probably should get this addressed somehow for 0.2.2, I hope?

comment:8 by Christopher Allan Webber, 12 years ago

Description: modified (diff)

Is this worth the effort at this point, really? If we did this, we have to do it across the entire mediagoblin codebase, not just javascript, is that right? That seems like contacting a lot of people.

If we include non-minimized javascript in the same directory as minimized javascript, shouldn't that be enough? Why not just distribute the source alongside the application to simplify things?

Maybe I should just close this as wontfix?

comment:9 by Christopher Allan Webber, 12 years ago

Resolution: wontfix
Status: acceptedclosed

Marking as wontfix and cc'ing brett on it. If brett still thinks it's worth re-opening, we'll re-open. Seems like a lot of re-licensing hassle at the moment though.

Note: See TracTickets for help on using tickets.