Change storage configuration in .ini

[Elrond]

The current configuration for the storage looks like this:

[mediagoblin]
publicstore_class = StorageBackend
publicstore_base_dir = %(here)s/user_dev/media/public
publicstore_base_url = /mgoblin_media/
publicstore_password = secret

Instead I suggest an alternative configuration scheme:

[storage:publicstore]
class = StorageBackend
base_dir = %(here)s/user_dev/media/public
base_url = /mgoblin_media/
password = secret

I implemented this on my dev/storage_config branch.

There is also an other config option with configobj, sub sub sections:

[storage]
  [ [ publicstore ] ]
  base_dir = %(here)s/user_dev/media/public
  base_url = /mgoblin_media/

  [ [ queuestore ] ]
  base_dir = %(here)s/user_dev/media/queue

I don't know, if this one is "better". I would prefer the first one.

[Christopher Allan Webber]

The first almost certainly seems better to me.

[Christopher Allan Webber]

Elrond, is your branch for this mergable in your opinion?

It's looking good to me. I only see a few things that are of issue:

• storage_system_from_config(config) should become storage_system_from_config(config_section) as we aren't now taking the whole config
• Arguments: in storage_system_from_config docstring should be updated to match reality.

I'm assigning this to Elrond because I don't understand why it was assigned to Joar. ;) If there's a good reason, assign it back.

[Elrond]

I assigned this to joar for testing. Because he has a setup which actually uses the storage config, so he could test these changes in the "real world".

Pushed a new commit on my branch to address documentation issues.

[Elrond]

joar, if you have some time, could you test this config scheme change with your CloudFiles? Just to see, if it makes sense to you?

[joar]

Hi Elrond, I agree with Christopher.

The first alternative seems easier on the eyes than the second alternative, and to ease the burden on site administrators, I think we should go with it.

Setting the CloudFiles settings in that way should not be a problem, but I guess that there need to be some changes in any code that utilizes the app_config?

These are the current options for CloudFiles: http://wiki.mediagoblin.org/Configure_MediaGoblin#Setting_up_Cloud_Files_public_storage

[Christopher Allan Webber]

Merged! I also fixed the tests appropriately also.

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/490 .