SMTP configuration options

[joar]

Add configuration options for SMTP connection.

[joar]

Merge request at https://gitorious.org/mediagoblin/mediagoblin/merge_requests/16

[Christopher Allan Webber]

Very close to being mergable, but a few things:

• What happened to mhost.connect()? Looks like it got removed... is this intentional?

• FakeMhost.login() should probably take args,*kwargs in case anyone passes anything in

• In this:

  if not mg_globals.app_config['email_smtp_host']:
      mhost = smtplib.SMTP()
  else:
      mhost = smtplib.SMTP(
          mg_globals.app_config['email_smtp_host'],
          mg_globals.app_config['email_smtp_port'])
  

Maybe the port should always be passed in to the first mhost = ? It has a default, so:

mhost = smtplib.SMTP(
    port=mg_globals.app_config['email_smtp_port'])

[joar]

Updated: https://gitorious.org/mediagoblin/mediagoblin/merge_requests/16

smtplib.SMTP.__init__ issues the connect() implicitly "if host"

Cheers, Joar

[Christopher Allan Webber]

-email_smtp_host = string(default=None)
+email_smtp_host = string(default='')

and always pulling in the email_smtp_host... I see what you did there ;)

Does that work, always passing in host='' just defaulting to localhost? I'm assuming you tested that!

Merged.

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/489 .
Relations:
#24: related