Opened 10 years ago

Closed 7 years ago

#178 closed enhancement (fixed)

Have a Users page that lists all the users on a given install

Reported by: Karen Rustad Owned by:
Priority: minor Milestone:
Component: programming Keywords:
Cc: Parent Tickets:

Description (last modified by Christopher Allan Webber)

Right now, I have no way of telling how many users are on the site
or any way of seeing their profiles (other than clicking on another
user's photo and clicking their name on the photo page). If we're
going to have user profiles, let's have a way of finding other
users!



Subtickets

Change History (19)

comment:1 Changed 10 years ago by Will Kahn-Greene

The original url for this bug was http://bugs.foocorp.net/issues/470 .

comment:2 Changed 10 years ago by Sacha

Milestone: 0.2.2
Owner: set to Sacha
Status: acceptedassigned

comment:3 Changed 10 years ago by Sacha

I made these changes, but I changed pagination.html so the paging widget now says "Next" and "Previous" instead of "Older" and "Newer"

Older and Newer just don't make sense for a list of users.

Also, this probably needs looking at by graphics/templating folks for two reasons:

  1. this page is only accessible by going to the /userlist.html page directly, there are no links to this list.
  1. It's a little ugly right now. Maybe a profile picture or something the user uploaded?

Changes are here:
https://gitorious.org/~chemhacker/mediagoblin/chemhackers-mediagoblin/commits/bug178_userlist

Last edited 10 years ago by Sacha (previous) (diff)

comment:4 Changed 10 years ago by Sacha

Owner: changed from Sacha to Christopher Allan Webber

comment:5 Changed 10 years ago by Christopher Allan Webber

Description: modified (diff)
Keywords: needs-review added

comment:6 Changed 10 years ago by Elrond

Owner: changed from Christopher Allan Webber to Elrond

Okay, will review (and merge) soon.

comment:7 Changed 10 years ago by Elrond

Keywords: needs-review removed
Owner: changed from Elrond to Sacha
Type: defectenhancement

Hi,

I looked at the patch.
It looks mostly good. I have to admit, I haven't tried it.

One improvement I would like to see before I merge this into master:
Move the check for status==active from the template into the db query. This should be as easy as ...db.User.find({status: 'active'}) (this is from my head, please verify it!). Just add a new commit to your branch changing this. And then assign the bug back to me and re-add a "needs-review" keyword/tag.

Thanks for your work!

comment:8 Changed 9 years ago by Christopher Allan Webber

Milestone: 0.3.00.3.1

comment:9 Changed 9 years ago by Christopher Allan Webber

I'll try to look at this today.

comment:10 Changed 9 years ago by Will Kahn-Greene

What's the status of this issue? Did this land for 0.3.1?

comment:11 Changed 9 years ago by spaetz

Milestone: 0.3.10.3.3

No, this has never landed. I merged the conflicts in routing.py, and moved the check for active users into views.py. Some minor template cleanups thrown in and pushed the updated patch from chemhacker to the branch bug178_userlist at my repo at git://gitorious.org/~spaetz/mediagoblin/spaetz-mediagoblin.git

What remains to be done: Actually put a link to the user list on some template where it fits. Not sure where. Also the user list template is pretty bare bone still (but better than nothing).

comment:12 Changed 9 years ago by Christopher Allan Webber

You are right, I have no idea where to put a link to this list of all users.

comment:13 Changed 9 years ago by Jef van Schendel

I think the reason we can't think of a good spot for a link is that we can't think of a good reason why we should have that link. Wouldn't a search function be a better solution to Karen's problem?

comment:14 Changed 9 years ago by Christopher Allan Webber

You may be right. A user list might be interesting on smallish installs but it would be fairly useless on large installs.

comment:15 Changed 9 years ago by Christopher Allan Webber

Milestone: 0.3.3

At any rate I'm dropping this from 0.3.3 until we have a better idea of what to do.

comment:16 Changed 9 years ago by Christopher Allan Webber

Status: assignedin_progress

Hi! I'm moving this ticket from "assigned" to in_progress per our new workflow. Please update the ticket and let us know if you're still working on this. If you are, super great! If not, we'll remove the claim and move it back to "accepted" in a couple of weeks.

Thanks!

comment:17 Changed 8 years ago by spaetz

If we don't keep the user's list, then let us at the very least make an administrators dashboard that shows, the number of users, posted media etc. This could include a search field to search for individual users, the search results which could show up in a list, like the user's list requested in this ticket. This list could then also provide "deactivate" and "delete" buttons for users other than one self.

comment:18 Changed 7 years ago by Jessica Tallon

I believe this has been done, if you're an administrator you are able to go to /mod/users/which will provide you with a user list. This was created as part of tilly-Q's moderation work. Specially the user list was introduced 6bba33 and refined to the current version in 6483b3.

Is this possible to be closed as fixed now?

comment:19 Changed 7 years ago by Jessica Tallon

Owner: Sacha deleted
Resolution: fixed
Status: in_progressclosed
Note: See TracTickets for help on using tickets.