Opened 13 years ago

Last modified 12 years ago

#177 closed defect (FIXED)

Comments on a photo should appear above the new comment form

Reported by: Karen Rustad Owned by: Aaron Williamson
Priority: minor Milestone: 0.1.0
Component: ui Keywords:
Cc: Parent Tickets:

Description

Right now, comments only appear after the new comment form on the
photo page. This makes them really easy to miss, so far down the
page.

Let's put the comments ahead of the new comment form -- so you
(hopefully) read what other people have written before writing
something new!



Change History (15)

comment:1 by Christopher Allan Webber, 13 years ago

Milestone: 0.0.5

comment:2 by Robin Holler, 13 years ago

Owner: set to Robin Holler

comment:3 by Christopher Allan Webber, 13 years ago

Milestone: 0.0.50.1.0

comment:1 by Christopher Allan Webber, 13 years ago

There's an opposite potential problem here that hasn't been raised.
If you have 30 comments to a page, you might never reach the
comment form, and we want people to talk.

Then again, that doesn't seem to be a problem here:
`http://creativecommons.org/weblog/entry/28403#comments <http://creativecommons.org/weblog/entry/28403#comments>`_

Curious what others think.



comment:2 by Christopher Allan Webber, 13 years ago

I guess we should do this after all :)

Robin, not sure if you're still around to do it..



comment:3 by Christopher Allan Webber, 13 years ago

(Adding Jef to see if he has commentary though)



comment:4 by Robin Holler, 13 years ago

Owner: set to Robin Holler

comment:4 by Robin Holler, 13 years ago

Still around here, still willing to help (definitely), but damn, my
bachelor thesis is detaining me ... have to move through the whole
of germany as well. So sorry, there will be more helpful times
soon! =)



comment:5 by Christopher Allan Webber, 13 years ago

Ok, thanks for the update Robin!



comment:6 by Aaron Williamson, 12 years ago

Owner: set to Aaron Williamson
Status: NewFeedback
Patch:
`https://gitorious.org/mediagoblin/mediagoblin/merge\_requests/27 <https://gitorious.org/mediagoblin/mediagoblin/merge_requests/27>`_

I also added a link at the top of the comments allowing the user to
jump below the comments to the comment form.



comment:7 by Elrond, 12 years ago

Hi. I only took a quick look! Generally looks fine.

Could you wrap the trans tag just around the string, not including
the html? It's not wrong the current way, but it would certainly
make translators' life easier.



comment:8 by Aaron Williamson, 12 years ago

Corrected trans tag issue, updated merge request.



comment:9 by Elrond, 12 years ago

Milestone: 0.1.00.2.0
Status: FeedbackClosed
Merged into my "reviewed" branch, which Chris Webber will hopefully
merge soon.

I've set the version to 0.1.1, as I think, this will go into 0.1.1,
especially, as it's not vital to 0.1.0.



comment:10 by Elrond, 12 years ago

Milestone: 0.2.00.1.0

comment:10 by Will Kahn-Greene, 12 years ago

The original url for this bug was http://bugs.foocorp.net/issues/469 .

Note: See TracTickets for help on using tickets.