Opened 9 years ago

Last modified 8 years ago

#1051 accepted enhancement

"Max file size: X mb" should state "MiB", not "mb".

Reported by: anongoblin Owned by:
Priority: trivial Milestone:
Component: graphic design/interface Keywords: size units
Cc: Parent Tickets:


First of all, thanks for your awesome work in Mediagoblin.

I know this might sound very picky and even stupid, but stating "MB", in caps, would be wrong, because the real unit used for files is, universally, but commonly misnamed, the mebibyte, MiB.

It's commonly misnamed as "MB" for historical reasons, and even if incorrect, I can understand the resistance to change.

But stating "mb" is wrong in all levels. Mega is "M", not "m" (which could be 'meters'), and "b" means bits, not bytes.

I'm providing a patch to be less annoying in case you feel this is an acceptable change. I hope it's well done, it comes from a "git diff"

Attachments (1)

gmg-mb-mib.patch (529 bytes ) - added by anongoblin 9 years ago.
Small patch replacing "mb" with "MiB" in the upload form

Download all attachments as: .zip

Change History (5)

by anongoblin, 9 years ago

Attachment: gmg-mb-mib.patch added

Small patch replacing "mb" with "MiB" in the upload form

comment:1 by anongoblin, 9 years ago

Component: programminggraphic design/interface

comment:2 by Ben Sturmfels, 9 years ago

Status: newreview

Hi Anongoblin,

Thanks for the patch, and sorry to see that it's gone unreviewed for such a long time. I'll mark the ticket as "review" so that one of the core developers will hopefully see it.

From my perspective, I know what an "MiB" is, but I don't think that MediaGoblin's target audience would (know or even be interested). I'd suggest that we use the widely known "MB" (decimal megabyte), then update the code to report the file size limits in bytes divided by 1,000,000. Would you be interested in having a go at this change? I'm happy to give you some help.

Additionally, we may want to update all the translation files to match your change, eg mediagoblin/i18n/cy/mediagoblin.po:1257. There are a whole lot of these for different languages.


comment:3 by Christopher Allan Webber, 8 years ago

This is a tricky patch to land, as all language here has serious problematic tradeoffs. I agree with Sturm's concerns, though since almost nobody uses the decimal megabyte, people maybe confused... why does my computer say this file is X megabytes, and MediaGoblin says it's Y?

So I suggest we either land this patch and accept that people will have to look up what a MiB is (they'll probably be able to guess) and also update all the gettext files (I agree that would need to be done), or just leave things as it is.

We shouldn't bikeshed on this forever, though I'd be happy to hear what's thought on the above.

comment:4 by Boris Bobrov, 8 years ago

Status: reviewaccepted
Note: See TracTickets for help on using tickets.