Opened 13 years ago
Last modified 13 years ago
#104 closed defect (FIXED)
Edit profile should be available to admins
Reported by: | Elrond | Owned by: | Caleb Davis |
---|---|---|---|
Priority: | trivial | Milestone: | 0.0.3 |
Component: | programming | Keywords: | |
Cc: | Parent Tickets: |
Description
admins should be able to edit any profile, not only their own. This shouldn't really be too hard to implement. Not really needed for 0.0.3, so leaving the target version open.
Change History (9)
comment:2 by , 13 years ago
mediagoblin has "admin users" (user.is\_admin = True). The current "edit your profile" allows people to edit their own url/bio. This is fine. :-) admin users should be able to edit the url/bio of any user. Why? To remove spam. On a second thought, this might not really be needed. Spam users should just be deleted...
comment:3 by , 13 years ago
Priority: | Normal → Low |
---|
I think it'll be valuable to have this, but that the priority is low. I think that if an admin is editing another user's profile though, it should have a clear message saying they aren't editing their own, and that with great power comes great responsibility.
comment:4 by , 13 years ago
Here's an example of where I think this is appropriate. Say we have a MediaGoblin instance running at Springfield Elementary where students can post their works online. However, Bart Simpson has put something completely inappropriate and rude in his profile making fun of his teacher. Principal Skinner, an admin, sees this and decides to take action. Now Bart is still a student and he doesn't want to **remove** Bart from the system, just that inappropriate message. So he deletes the biography but not the user and sends off a note via the hall monitor that Bart should see him in his office after class.
comment:6 by , 13 years ago
Milestone: | → 0.0.3 |
---|
The issue is mostly resolved so I took the liberty of adding the target version and % done. [https://gitorious.org/\ :sub:`cfdv/mediagoblin/cfdvs-mediagoblin/commits/b388+b391\_admin\_can\_edit\_user\_profile](https://gitorious.org/`\ cfdv/mediagoblin/cfdvs-mediagoblin/commits/b388+b391\_admin\_can\_edit\_user\_profile) The edit\_profile controller wasn't configured to allow editing of non-self profiles. In IRC the decision was to pass a username in the querystring to edit\_profile, which would only check the querystring if the user was an administrator. Otherwise, anything in the querystring is ignored. I made an admin section in templates/mediagoblin because it seemed like a part of gmg that could grow a lot. For now, administration is displayed in /. I also added a warning to the new message queue to remind the admins what they are doing. :) Cool!?
comment:7 by , 13 years ago
[https://gitorious.org/\ :sub:`cfdv/mediagoblin/cfdvs-mediagoblin/commits/b388+b391\_edit\_profile\_link\_on\_user\_page](https://gitorious.org/`\ cfdv/mediagoblin/cfdvs-mediagoblin/commits/b388+b391\_edit\_profile\_link\_on\_user\_page) This is a different version that moves the edit profile link to the user page.
Note:
See TracTickets
for help on using tickets.