Opened 12 years ago
Closed 11 years ago
#954 closed defect (fixed)
plain text <br/>
| Reported by: | anongoblin | Owned by: | |
|---|---|---|---|
| Priority: | trivial | Milestone: | 0.9.0 |
| Component: | programming | Keywords: | |
| Cc: | Parent Tickets: |
Description
After trying to register with cookies disabled, I get the 403 error. There is a plain text <br /> in the explanation:
CSRF cookie not present. This is most likely the result of a cookie blocker or somesuch.<br/>Make sure to permit the settings of cookies for this domain.
Attachments (3)
Change History (7)
comment:1 by , 11 years ago
| Status: | new → review |
|---|
by , 11 years ago
| Attachment: | issue_954.patch added |
|---|
comment:2 by , 11 years ago
I should point out that the above replacements were made in batch and I've checked them all to ensure that no other changes were made.
comment:3 by , 11 years ago
I just noticed a small grammatical error in that message: "settings of" should be "setting of" so have also fixed that in an updated patch.
by , 11 years ago
| Attachment: | issue_954.2.patch added |
|---|
by , 11 years ago
| Attachment: | issue_954.3.patch added |
|---|
Whoops, previous attachment didn't include second round of changes.
comment:4 by , 11 years ago
| Milestone: | → 0.9.0 |
|---|---|
| Resolution: | → fixed |
| Status: | review → closed |
Wow, nice job Sturm! Hoo, that's a lot of lines changed! :)
Merged and pushed!
Note:
See TracTickets
for help on using tickets.
I've confirmed this issue. The cause is that the error message is a safe string, so the
<br/>is being escaped.Grammatically, there's no need for the line break though, so I've attached a patch removing it from all translations.