Opened 10 years ago

Closed 8 years ago

#950 closed enhancement (fixed)

Add collection add/remove plugin hooks

Reported by: Odin Hørthe Omdal (Velmont) Owned by:
Priority: major Milestone:
Component: programming Keywords:
Cc: Elrond, Christopher Allan Webber Parent Tickets:

Description

I need this for a plugin :)

Attachments (2)

0001-Add-new-hook-add_media_to_collection.patch​ (3.3 KB ) - added by Odin Hørthe Omdal (Velmont) 10 years ago.
0002-Add-new-hook-remove_media_from_collection.patch​ (4.3 KB ) - added by Odin Hørthe Omdal (Velmont) 10 years ago.

Download all attachments as: .zip

Change History (8)

by Odin Hørthe Omdal (Velmont), 10 years ago

Attachment: 0001-Add-new-hook-add_media_to_collection.patch​ added

by Odin Hørthe Omdal (Velmont), 10 years ago

Attachment: 0002-Add-new-hook-remove_media_from_collection.patch​ added

comment:1 by Odin Hørthe Omdal (Velmont), 10 years ago

Status: new → review

comment:2 by Elrond, 10 years ago

Okay, collection_add_media added from your branch!

comment:4 by Christopher Allan Webber, 8 years ago

Sorry for the lonnnnnng delay in getting to this.

I'm fine with adding this hook I think, though I'm a bit unsure... is the last the branch version of this, and is that what I should merge? Or should I merge the patches?

I'd assume the latter but I'm a bit confused by Elrond's comment; I don't know what it means!

comment:5 by Odin Hørthe Omdal (Velmont), 8 years ago

I actually think I have integrated this :) I think the hook exists. Unless I'm running a patched version and haven't updated in a long while. Indeed it is there, even documented:

​https://mediagoblin.readthedocs.org/en/stable/pluginwriter/hooks.html

comment:6 by Odin Hørthe Omdal (Velmont), 8 years ago

Resolution: → fixed
Status: review → closed
Note: See TracTickets for help on using tickets.