Clean up Federation

[Jessica Tallon]

Elrond found some issues over his review of the federation code recently merged. These need fixing before 0.7.0.

Garbage Collection

• This task should be moved to submit
• This task uses the wrong operator in garbage collection (greater than rather than less then)
• The test sets entry.uploaded not entry.created ergo doesn't do anything.
• Logging is wrong.
• Use spaces not tabs! (WTF jess).

Feed Endpoint

• The comment is wrong (should say list all media not the users media).

Whoami Endpoint

• Doesn't handle the case where I might not be logged in

MediaComment.unserialize

• Needs to do more checking that all the data I want to look up in the dictionary exists to avoid KeyErrors.

Mediagoblin INI/Config file

• Should remove garbage_collection setting to spec file and remove it from mediagoblin.ini as it won't be commonly set.

json_error

• On the idea of:

  def json_error(error_str, status=400):
      return json_response({"error": error_str}, status=status)
  

• I am not sure, where to put this, either in the general response place, where json_response is also, or maybe only where it's being used in the federation code. If I have to vote, I'd likely vote for the former.

media_type/image: api_* upload utils

• Those staticmethod functions are really a specialized variant of submit/lib.py:submit_media().
• As only the pump.io/federation code uses it, please move this into federation/lib.py
• In the long run, this should be refactored together with submit/lib.py to provide a consistent upload api for everybody, again.

If any more issues are found please add them to this ticket. This is a rather large issue but most of the tasks in them are so small it doesn't warrant splitting them up.

[Elrond]

Add json_error idea.

[Elrond]

Fix Cut'n'paste issue. Add placement comment.

[Jessica Tallon]

I believe all of the current ticket has been done now. I have put the code on a ​federation branch on the mediagoblin repo so Elrond can review. Let me know if there are any issues with those changes.