Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#906 closed defect (fixed)

Sidebar info not showing up in media displays

Reported by: Rodrigo Rodrigues da Silva Owned by:
Priority: minor Milestone: 0.7.0
Component: graphic design/interface Keywords:
Cc: Parent Tickets:

Description

In commit acfcaf6366bd4695c1c37c7aa8ff5a176b412e2a, block mediagoblin_sidebar was removed from user_pages/media.html

Although, several media types rely on it to display extra information. I am supposing this was removed by accident, and not by design (which would, in some way, make sense since the commit is related to metadata stuff).

I've written a patch to put the block back in place. Actually I've placed it before the media_sideinfo template hook.

Anyway, this brings another discussion, since there are many different ways to "add" info to the sidebar: by extending the template, via template hooks, various includes and so on. Maybe we should have further thoughts and developments around this.

Attachments (1)

issue_906.patch (852 bytes ) - added by Rodrigo Rodrigues da Silva 11 years ago.

Download all attachments as: .zip

Change History (4)

by Rodrigo Rodrigues da Silva, 11 years ago

Attachment: issue_906.patch added

comment:1 by Rodrigo Rodrigues da Silva, 11 years ago

Status: newreview

comment:2 by Rodrigo Rodrigues da Silva, 11 years ago

Milestone: 0.7.0

comment:3 by Christopher Allan Webber, 11 years ago

Resolution: fixed
Status: reviewclosed

Looks good. Merged and pushed!

Note: See TracTickets for help on using tickets.