Opened 10 years ago
Closed 10 years ago
#902 closed defect (fixed)
Welcome image URL hard coded in the template
Reported by: | Jaakko Luttinen | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | programming | Keywords: | |
Cc: | Parent Tickets: |
Description
In mediagoblin/templates/mediagoblin/bits/frontpage_welcome.html there is a line:
<img class="welcomeimage" src="/mgoblin_static/images/home_goblin.png">
which I think should be:
<img class="welcomeimage" src="{{ request.staticdirect('/images/home_goblin.png') }}">
Otherwise the Goblin image on the front page does not load if mediagoblin directory is not the root directory of the vhost.
Change History (3)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
Status: | new → review |
---|
comment:3 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | review → closed |
Merged in https://gitorious.org/mediagoblin/mediagoblin/commit/c8c09bc43b91c0c78ad281e66aee713ff991909a. Thanks Jaakko!
The proposed fix (branch ticket-902):
https://gitorious.org/mediagoblin/jluttines-mediagoblin/source/867d01749a2d5818d3508f362bb4bd5ad2b28d51: