Opened 9 years ago
Closed 9 years ago
#861 closed enhancement (fixed)
Use STARTTLS when sending emails
|Reported by:||Matt Molyneaux||Owned by:|
Currently MediaGoblin only has the option of using plain SMTP or SMTP over SSL (which has deprecated for some time now). Using STARTTLS is completely unsupported.
These changes address this issue by attempting to use the STARTTLS command after EHLO/HELO. By default it will carry on as normal if STARTTLS command is unavailable, this can be changed by setting
email_smtp_force_tls in the config.
Before this can be considered for merging there are two things that need to be taken care of:
- Unit test - I have no idea how to change
email_smtp_force_tlsat runtime, so I can't test this config option in both states.
- Documentation - I can't see where
email_smtp_*are documented. In particular, settings
email_smtp_force_tlsmight confuse users
Patches can be found on the "starttls" branch of this git repo: https://gitorious.org/mediagoblin/mediagoblin-starttls/commits/starttls
Change History (10)
comment:1 by , 9 years ago
|Status:||new → review|
comment:2 by , 9 years ago
comment:3 by , 9 years ago
comment:4 by , 9 years ago
But stupidly, I merged it before realizing that there were those two things above that needed addressing!
comment:5 by , 9 years ago
The documentation issue appears to have already been reported as #734
comment:6 by , 9 years ago
|Status:||review → in_progress|
by , 9 years ago
Patch to add documentation and unit tests
comment:7 by , 9 years ago
I have attached a patch which adds documentation and unit tests to cover the addition of the force email_smtp_force_starttls option (renamed from email_smtp_force_tls to reduce ambiguity).
comment:8 by , 9 years ago
Ah yes, I probably should have named it that way in the first place. Good catch :)
comment:9 by , 9 years ago
|Status:||in_progress → closed|
This is fixed as of 7ffd4cf.
Rebased branch on 8917ffb1e73ac8ed0fc825113593e5e5ca9b4573 (current HEAD)