Opened 9 years ago
Closed 2 years ago
#848 closed defect (fixed)
decide what to do about mediagoblin/source/extlib/freesound/audioprocessing.py
|Reported by:||Simon Fondrie-Teitler||Owned by:|
MediaGoblin currently includes the file audioprocessing.py (0) in extlib/. This file is from the fresound.org website source code (1), but has changes (2) in the MediaGoblin version. I was thinking that the changes would need to be added to freesound and it packaged, but when I realized it's the source code for a website, and a full django app, making freesound a dependency sounded insane. So I'm guessing that's not the right way to go.
Right now I'm thinking we just add it to the main source code.
Change History (5)
comment:1 by , 9 years ago
|Parent Tickets:||→ 518|
comment:2 by , 9 years ago
|Status:||new → in_progress|
comment:3 by , 9 years ago
comment:4 by , 9 years ago
One answer is to ask mediagoblin folks to separately package (in the Python package sense: setup.py) their modified version of just this one file/module.
After you do that, you might see if the freesound folks would be interested in co-maintaining that.
Note that it is possible (though vaguely weird, but totally possible) to have that package live in the freesound git repo; one git repo can generate multiple "Python packages".
Then, you can get that into PyPI & Debian in the fullness of time.
comment:5 by , 2 years ago
|Status:||in_progress → closed|
Closing - fixed in 0.11.0 by removing audioprocessing.py.
Given that there isn't an easy way to deal with this dependency, and that you have local changes, and that freesound isn't already in the Debian archive (if I understand correctly), I recommend you simply remark on this in debian/copyright and do an initial upload to Debian, and deal with this later.
i.e., don't consider it a showstopper.