Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#828 closed defect (fixed)

Reversed arrows (RTL bug)

Reported by: Genghis Khan Owned by:
Priority: minor Milestone: 1.0
Component: graphic design/interface Keywords: rtl, bitesized
Cc: Aleksej, Jiyda Mint Moussa, osamak Parent Tickets:


Arrows of ← newer older → are reversed → newer older ← on RTL locale.

Current→ اجدد اقدم ←
Desired← اجدد اقدم →

I think it would be fine if it would be ordered like the one below, if that would be easier to fix, but please confirm with Arabic and Farsi users beforehand.
← اقدم اجدد →

Tested at

Attachments (2)

0001-fixed-older-and-newer-arrows-for-rtl-locales.patch (2.3 KB ) - added by Leah Velleman 8 years ago.
0002-use-is_rtl-variable-to-detect-rtl-locales.patch (1.0 KB ) - added by Leah Velleman 8 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 by Genghis Khan, 10 years ago

When reducing display with to 940px ← newer older → is displayed like this اقدم → ← اجدد which makes more logic even though this order ← اقدم اجدد → would be more appropriate.

comment:2 by Christopher Allan Webber, 10 years ago

Keywords: bitesized added

This would be a good bitesized bug for someone wanting to jump into this part of the codebase.

comment:3 by Christopher Allan Webber, 8 years ago

Resolution: fixed
Status: newclosed

Looks good! I've pushed it! Thank you! :)

comment:4 by Christopher Allan Webber, 8 years ago

Milestone: 1.0

So I've pushed this fix, but I just realized that one improvement could be made. With this line:

{% if request.locale.startswith("fa") or request.locale.startswith("ar") %}

I believe we have a variable in the environment, is_rtl , which could similarly be used. Would you be interested in trying adding an additional patch which uses that variable? That way if we add languages to the list of RTL languages, that information can be used both here and elsewhere.


comment:5 by Christopher Allan Webber, 8 years ago

Merged that one too, thank you!

Note: See TracTickets for help on using tickets.