#828 closed defect (fixed)
Reversed arrows (RTL bug)
| Reported by: | Genghis Khan | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.0 |
| Component: | graphic design/interface | Keywords: | rtl, bitesized |
| Cc: | Aleksej, Jiyda Mint Moussa, osamak | Parent Tickets: |
Description
Arrows of ← newer older → are reversed → newer older ← on RTL locale.
| Current | → اجدد اقدم ← |
| Desired | ← اجدد اقدم → |
I think it would be fine if it would be ordered like the one below, if that would be easier to fix, but please confirm with Arabic and Farsi users beforehand.
← اقدم اجدد →
Tested at http://74.122.197.234:6543/u/dradtke/m/i-has-strawberry/
Attachments (2)
Change History (7)
comment:1 by , 11 years ago
comment:2 by , 11 years ago
| Keywords: | bitesized added |
|---|
This would be a good bitesized bug for someone wanting to jump into this part of the codebase.
by , 8 years ago
| Attachment: | 0001-fixed-older-and-newer-arrows-for-rtl-locales.patch added |
|---|
comment:3 by , 8 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Looks good! I've pushed it! Thank you! :)
comment:4 by , 8 years ago
| Milestone: | → 1.0 |
|---|
So I've pushed this fix, but I just realized that one improvement could be made. With this line:
{% if request.locale.startswith("fa") or request.locale.startswith("ar") %}
I believe we have a variable in the environment, is_rtl , which could similarly be used. Would you be interested in trying adding an additional patch which uses that variable? That way if we add languages to the list of RTL languages, that information can be used both here and elsewhere.
Thanks!
by , 8 years ago
| Attachment: | 0002-use-is_rtl-variable-to-detect-rtl-locales.patch added |
|---|
When reducing display with to 940px ← newer older → is displayed like this اقدم → ← اجدد which makes more logic even though this order ← اقدم اجدد → would be more appropriate.