Opened 6 years ago

Closed 4 years ago

Last modified 4 years ago

#828 closed defect (fixed)

Reversed arrows (RTL bug)

Reported by: Genghis Khan Owned by:
Priority: minor Milestone: 1.0
Component: graphic design/interface Keywords: rtl, bitesized
Cc: Aleksej, Jiyda Mint Moussa, osamak Parent Tickets:

Description

Arrows of ← newer older → are reversed → newer older ← on RTL locale.

Current→ اجدد اقدم ←
Desired← اجدد اقدم →

I think it would be fine if it would be ordered like the one below, if that would be easier to fix, but please confirm with Arabic and Farsi users beforehand.
← اقدم اجدد →

Tested at http://74.122.197.234:6543/u/dradtke/m/i-has-strawberry/

Subtickets

Attachments (2)

0001-fixed-older-and-newer-arrows-for-rtl-locales.patch (2.3 KB) - added by Leah Velleman 4 years ago.
0002-use-is_rtl-variable-to-detect-rtl-locales.patch (1.0 KB) - added by Leah Velleman 4 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 6 years ago by Genghis Khan

When reducing display with to 940px ← newer older → is displayed like this اقدم → ← اجدد which makes more logic even though this order ← اقدم اجدد → would be more appropriate.

comment:2 Changed 6 years ago by Christopher Allan Webber

Keywords: bitesized added

This would be a good bitesized bug for someone wanting to jump into this part of the codebase.

Changed 4 years ago by Leah Velleman

comment:3 Changed 4 years ago by Christopher Allan Webber

Resolution: fixed
Status: newclosed

Looks good! I've pushed it! Thank you! :)

comment:4 Changed 4 years ago by Christopher Allan Webber

Milestone: 1.0

So I've pushed this fix, but I just realized that one improvement could be made. With this line:

{% if request.locale.startswith("fa") or request.locale.startswith("ar") %}

I believe we have a variable in the environment, is_rtl , which could similarly be used. Would you be interested in trying adding an additional patch which uses that variable? That way if we add languages to the list of RTL languages, that information can be used both here and elsewhere.

Thanks!

Changed 4 years ago by Leah Velleman

comment:5 Changed 4 years ago by Christopher Allan Webber

Merged that one too, thank you!

Note: See TracTickets for help on using tickets.