Test authentication views

[Christopher Allan Webber]

Authentication views untested, need to test them!

[Christopher Allan Webber]

Registration testing is handled, most of email verification testing
too. Login/logout testing is mostly what's left afaict.

[Christopher Allan Webber]

Assigning to Chris Moylan (djmoymoy / cmoylan) who has volunteered
to work on this. Thanks Chris!

[Chris Moylan]

Logins now have thin test coverage.

[Christopher Allan Webber]

Presumably you mean
[https://gitorious.org/\ :sub:`cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test\_auth\_views\_364](https://gitorious.org/`\ cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test\_auth\_views\_364)
:)

(It's best that you link to the branch so I know where your stuff
is so I can merge it easily.)

Anyway, the quality of this test looks really great. I'd love to
see a few more components added to this test though:


-  Testing for logout
-  Testing for attempting to log in with a wrong password (make
   sure 'login\_failed' context is True)
-  Testing for attempting to log in with a bogus user (make sure
   'login\_failed' context is True)
-  (less critical but would still be good:) Testing redirects after
   successful submit, both for when next=True and when not.

Looking great, excited to have you joining our team!

[Christopher Allan Webber]

Elrond has pointed out that there's no reason **not** to merge at
this point, as the tests are incomplete but work, so doing so now.
Would still love to see the rest of this done though!

[Chris Moylan]

Sorry about not posting the link to the branch. I was going to
finish it before requesting a pull.

[Chris Moylan]

Added tests for missing and incorrect form fields.
Added testing of custom redirects when the 'next' parameter is
set.

As noted above, branch is here:
[https://gitorious.org/\ :sub:`cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test\_auth\_views\_364](https://gitorious.org/`\ cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test\_auth\_views\_364)

[Chris Moylan]

Changing status to resolved unless anyone has any additional ideas
for test coverage.

[Christopher Allan Webber]

Yeah, this looks super great! Merged, pushed.

[Will Kahn-Greene]

The original url for this bug was ​http://bugs.foocorp.net/issues/364 .
Relations:
#23: blocked