Opened 12 years ago
Last modified 12 years ago
#79 closed defect (FIXED)
Test authentication views
|Reported by:||Christopher Allan Webber||Owned by:||Chris Moylan|
Authentication views untested, need to test them!
Change History (10)
comment:1 by , 12 years ago
comment:2 by , 12 years ago
Assigning to Chris Moylan (djmoymoy / cmoylan) who has volunteered to work on this. Thanks Chris!
comment:3 by , 12 years ago
Logins now have thin test coverage.
comment:4 by , 12 years ago
Presumably you mean [https://gitorious.org/\ :sub:`cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test\_auth\_views\_364](https://gitorious.org/`\ cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test\_auth\_views\_364) :) (It's best that you link to the branch so I know where your stuff is so I can merge it easily.) Anyway, the quality of this test looks really great. I'd love to see a few more components added to this test though: - Testing for logout - Testing for attempting to log in with a wrong password (make sure 'login\_failed' context is True) - Testing for attempting to log in with a bogus user (make sure 'login\_failed' context is True) - (less critical but would still be good:) Testing redirects after successful submit, both for when next=True and when not. Looking great, excited to have you joining our team!
comment:5 by , 12 years ago
Elrond has pointed out that there's no reason **not** to merge at this point, as the tests are incomplete but work, so doing so now. Would still love to see the rest of this done though!
comment:6 by , 12 years ago
Sorry about not posting the link to the branch. I was going to finish it before requesting a pull.
comment:7 by , 12 years ago
Added tests for missing and incorrect form fields. Added testing of custom redirects when the 'next' parameter is set. As noted above, branch is here: [https://gitorious.org/\ :sub:`cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test\_auth\_views\_364](https://gitorious.org/`\ cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test\_auth\_views\_364)
comment:8 by , 12 years ago
|Status:||New → Resolved|
Changing status to resolved unless anyone has any additional ideas for test coverage.
comment:9 by , 12 years ago
|Status:||Resolved → Closed|
Yeah, this looks super great! Merged, pushed.
comment:10 by , 11 years ago
The original url for this bug was http://bugs.foocorp.net/issues/364 .
Note: See TracTickets for help on using tickets.