Opened 15 years ago
Last modified 15 years ago
#79 closed defect (FIXED)
Test authentication views
| Reported by: | Christopher Allan Webber | Owned by: | Chris Moylan |
|---|---|---|---|
| Priority: | minor | Milestone: | 0.0.3 |
| Component: | programming | Keywords: | |
| Cc: | Parent Tickets: |
Description
Authentication views untested, need to test them!
Change History (10)
comment:1 by , 15 years ago
comment:2 by , 15 years ago
| Owner: | changed from to |
|---|
Assigning to Chris Moylan (djmoymoy / cmoylan) who has volunteered to work on this. Thanks Chris!
comment:4 by , 15 years ago
Presumably you mean [https://gitorious.org/cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test_auth_views_364](https://gitorious.org/cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test_auth_views_364) :)
(It's best that you link to the branch so I know where your stuff is so I can merge it easily.)
Anyway, the quality of this test looks really great. I'd love to see a few more components added to this test though:
- Testing for logout
- Testing for attempting to log in with a wrong password (make sure 'login_failed' context is True)
- Testing for attempting to log in with a bogus user (make sure 'login_failed' context is True)
- (less critical but would still be good:) Testing redirects after successful submit, both for when next=True and when not.
Looking great, excited to have you joining our team!
comment:5 by , 15 years ago
Elrond has pointed out that there's no reason not to merge at this point, as the tests are incomplete but work, so doing so now. Would still love to see the rest of this done though!
comment:6 by , 15 years ago
Sorry about not posting the link to the branch. I was going to finish it before requesting a pull.
comment:7 by , 15 years ago
Added tests for missing and incorrect form fields. Added testing of custom redirects when the 'next' parameter is set.
As noted above, branch is here: [https://gitorious.org/cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test_auth_views_364](https://gitorious.org/cmoylan/mediagoblin/cmoylan-mediagoblin/commits/test_auth_views_364)
comment:8 by , 15 years ago
| Status: | New → Resolved |
|---|
Changing status to resolved unless anyone has any additional ideas for test coverage.
comment:10 by , 14 years ago
The original url for this bug was http://bugs.foocorp.net/issues/364 .
Relations:
#23: blocked
Registration testing is handled, most of email verification testing too. Login/logout testing is mostly what's left afaict.