Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#762 closed enhancement (fixed)

simplify user.html

Reported by: spaetz Owned by:
Priority: minor Milestone: 0.6.0
Component: programming Keywords: review
Cc: Parent Tickets:


When looking at user.html in order to have plugins insert content, I found that it is horrible. The logic of whether a user is activated and what to display in that case is fully embedded in the template. Having this amount of logic in your template makes it slow and hard to develop alternative themes.

I patched it to use user_nonactive.html in case we have a non-yet active user (or one that was disabled).

Please review and pull the "master" branch at my repo:
git@…:mediagoblin/spaetz-mediagoblin.git (it is still the same address as earlier on).

This is the commit in question:

Change History (4)

comment:1 by spaetz, 11 years ago

Keywords: review added

comment:2 by spaetz, 11 years ago

Priority: majorminor
Status: newreview
Type: defectenhancement

comment:3 by Christopher Allan Webber, 11 years ago

Resolution: fixed
Status: reviewclosed

Nice simplification! Merged into master! :)

comment:4 by Christopher Allan Webber, 11 years ago

Milestone: 0.6.0
Note: See TracTickets for help on using tickets.