Opened 13 years ago

Last modified 13 years ago

#69 closed defect (FIXED)

edit media details

Reported by: Elrond Owned by: Jef van Schendel
Priority: trivial Milestone: 0.0.3
Component: ui Keywords:
Cc: Parent Tickets:


It should be possible to edit the title, description, slug and
maybe other things.

In the long run, it might be needed to even replace the media. But
this is probably another item.

Change History (12)

comment:1 by Elrond, 13 years ago

I have started a devel branch here:

[\ :sub:`elrond/mediagoblin/elronds-mediagoblin/commits/dev/media\_edit](`\ elrond/mediagoblin/elronds-mediagoblin/commits/dev/media\_edit)

Comments, suggestions, merge request welcome.

Current issues:

-  Any logged in user can edit any media
-  No checks on the entered values
-  exception from .save() not handled (what could happen? How to

comment:2 by Elrond, 13 years ago

-  located as "/edit/{media\_id}/". Maybe something like
   /u/{user}/m/{media\_id}/edit/ would be better.

Note that I would suggest using media\_id instead of the slug for
the edit things, as the slug itself can be edited and we might want
a static URL for at least the edit page.

cwebber has volunteered to fixup the url/routing. So I leave that
part to him.

comment:3 by Elrond, 13 years ago

Milestone: 0.0.3
Owner: set to Elvenlord Elrond

comment:3 by Elrond, 13 years ago

Component: Programming
Status: NewIn Progress
-  permission check is now there (admins and the uploader can
   change things)
-  Preparation for moving under /u/ also there. What's left?
-  permission check probably should be moved in some (will
   do soon)
-  No checks on the entered values
-  exception from .save() not handled. Especially a duped slug will
   give an exception. How to handle that?

comment:4 by Christopher Allan Webber, 13 years ago

Looked at your latest changes, and I think this is near mergable.
Only one thing left, and that's that I think the way the duplicate
slug error happens is wrong.

-  try: catch Exception: is gross because it catches way too many
   things. See also:
   ` <>`_
-  I would like it if we could actually display the error inside
   the form. See the register() view for more info on how to do this.
-  I really honestly think the cleanest way to handle things is to
   simply do a query to see if such an uploader, slug pair exists. Yes
   I know, it's "kind of" duplicated functionality, but there's no
   nice way to extract what exactly broke during validation. I think
   validation should be a last resort to make sure our models have
   kept their right form and to prevent very, very rare race
   conditions (the chance of a user actually updating two MediaEntries
   at once to the same slug this way is super low but worth preventing
   from a data integrity standpoint).

comment:5 by Elrond, 13 years ago

I would prefer it, if someone else could handle the remaining
issues. To put it simple, I'm currently exhausted on this.

You might consider to merge it in the current state and leave the
bug open. That way anyone interested to continue this can start
from the main repository. This includes the UI design team (read
"schendje"). IMHO the whole thing works okay and all the remaining
issues can be fixed "in the normal tree" (like btrfs was merged

comment:6 by Christopher Allan Webber, 13 years ago

That's fine, I can handle the rest. Thanks for your work on this,
Elrond. :)

comment:7 by Christopher Allan Webber, 13 years ago

Owner: changed from Elvenlord Elrond to Christopher Webber

comment:7 by Christopher Allan Webber, 13 years ago

Status: In ProgressClosed
Merged Elrond's work and made the changes discussed. Thanks for
your work on this Elrond!

comment:8 by Elrond, 13 years ago

Component: ProgrammingGraphic Design / UI
Owner: changed from Christopher Webber to Jef van Schendel
Priority: NormalLow
Status: ClosedIn Progress
Thanks Chris!

Reopening as discussed a while back with schendje and reassigning
to him.
I would like the UI team to take a quick look at the "edit media
details" page. I put a thumbnail of the picture there, so that one
sees the media in question. But I have no plan on a good position
for it.

Another simple question: Where to put the "Edit"-link on the main
media page?

This is low priority, as things work and don't look too bad. So if
the UI team has a few spare minutes, it would be nice, but
certainly not needed.

comment:9 by Elrond, 13 years ago

Status: In ProgressClosed
I think this iteration is done. All looks fine.

If you don't agree, complain here or open a new bug.

comment:10 by Will Kahn-Greene, 12 years ago

The original url for this bug was .

Note: See TracTickets for help on using tickets.