Opened 9 years ago

Closed 7 years ago

#681 closed enhancement (fixed)

replace mediagoblin.ini for mediagoblin.ini.sample

Reported by: nico cesar Owned by:
Priority: minor Milestone: 0.8.0
Component: programming Keywords: bitesized
Cc: Parent Tickets:

Description

I feel more natural using ".sample" suffix instead of having 2 confusing .ini files

Subtickets

Change History (6)

comment:1 Changed 8 years ago by Christopher Allan Webber

Keywords: bitesized added
Status: newaccepted

This is a good idea, and a bitesized issue for whoever might want to take it on.

There are really only three steps I think:

  • do a git mv mediagoblin.ini mediagoblin.ini.sample
  • Add a makefile rule to do this copy if mediagoblin.ini does not exist.
  • Update docs if needed, which given the makefile update, it might not be needed at all.

comment:2 Changed 8 years ago by Quint Guvernator

Owner: set to Quint Guvernator
Status: acceptedin_progress

comment:3 in reply to:  1 Changed 8 years ago by Quint Guvernator

Replying to cwebber:

  • Add a makefile rule to do this copy if mediagoblin.ini does not exist.
  • Update docs if needed, which given the makefile update, it might not be needed at all.

Exactly what should be done here? Should a cp operation be hard-coded into Makefile.in? If so, should this command be added under install?

So far, I've renamed the file and added *.ini.sample to the recursive-includes in MANIFEST.in.

comment:4 Changed 7 years ago by Christopher Allan Webber

Milestone: 0.8.0

This really ought to happen. Moving to 0.8.0.

Our makefile situation is pretty... unclear at the moment. As such, I suggest this being a docs change, among other things.

Bonus points if mediagoblin doesn't see the file and does the copying itself. I think that would actually make this easiest.

comment:5 Changed 7 years ago by Christopher Allan Webber

qguv, not sure if you're still interested in working on this... (sorry about the long delay on replying, too). Let me know.

comment:6 Changed 7 years ago by Christopher Allan Webber

Owner: Quint Guvernator deleted
Resolution: fixed
Status: in_progressclosed

Closing. We are now using mediagoblin.example.ini, and the makefile does things right.

Note: See TracTickets for help on using tickets.